[native] account for reactions in message item height methods
AbandonedPublic
Actions

Authored by ginsu on Dec 5 2022, 6:21 PM.

Details

Reviewers

atul
rohan
tomek

Summary

Previously we were not considering reactions so this would create an incorrect height measurement. This would cause the animation when the InlineSidebar would get rendered to be glitchy

Depends on D5813
Linear Task: ENG-2048

Test Plan

Before the changes I was getting this error message in my logs; however, after the changes the error message went away

Screenshot 2022-12-05 at 9.34.38 PM.png (1×3 px, 939 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Dec 5 2022, 6:21 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 5 2022, 6:21 PM

Harbormaster completed remote builds in B13984: Diff 19157.Dec 5 2022, 6:30 PM

ginsu requested review of this revision.Dec 5 2022, 6:30 PM

ginsu edited the summary of this revision. (Show Details)Dec 5 2022, 6:37 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, rohan, tomek.

ginsu added a parent revision: D5813: [native] introduce reactions to inline sidebar.

ginsu attached a referenced file: F272519: Screenshot 2022-12-05 at 9.34.38 PM.png. (Show Details)

It might be a good idea to see what happens when someone else reacts when an overlay is visible.

atul accepted this revision.Dec 7 2022, 12:01 PM

This revision is now accepted and ready to land.Dec 7 2022, 12:01 PM

ginsu mentioned this in D5812: [native] introduced reactions to chat item height measurer.Dec 12 2022, 8:33 PM

Abandoning because merged this diff with D5812

Revision Contents
Changeset List

Path

Size

native/

chat/

multimedia-message-utils.js

2 lines

utils.js

4 lines

Diff 19157

View Options

native/chat/multimedia-message-utils.js