Page MenuHomePhabricator
Differential D5815

[native] account for reactions in message item height methods
AbandonedPublic
Actions

Authored by ginsu on Dec 5 2022, 6:21 PM.
Tags
None
Referenced Files
F4947079: D5815.diff
Wed, Mar 19, 12:18 PM
Unknown Object (File)
Mon, Mar 17, 6:05 AM
Unknown Object (File)
Mon, Mar 17, 6:04 AM
Unknown Object (File)
Mon, Mar 17, 5:58 AM
Unknown Object (File)
Tue, Feb 25, 5:26 PM
Unknown Object (File)
Mon, Feb 24, 5:36 AM
Unknown Object (File)
Feb 13 2025, 4:59 PM
Unknown Object (File)
Feb 13 2025, 4:58 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
rohan
tomek
Summary

Previously we were not considering reactions so this would create an incorrect height measurement. This would cause the animation when the InlineSidebar would get rendered to be glitchy

Depends on D5813
Linear Task: ENG-2048

Test Plan

Before the changes I was getting this error message in my logs; however, after the changes the error message went away

Screenshot 2022-12-05 at 9.34.38 PM.png (1×3 px, 939 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Dec 5 2022, 6:21 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 5 2022, 6:21 PM
Harbormaster completed remote builds in B13984: Diff 19157.Dec 5 2022, 6:30 PM
ginsu requested review of this revision.Dec 5 2022, 6:30 PM
ginsu edited the summary of this revision. (Show Details)Dec 5 2022, 6:37 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, tomek.
ginsu added a parent revision: D5813: [native] introduce reactions to inline sidebar.
ginsu attached a referenced file: F272519: Screenshot 2022-12-05 at 9.34.38 PM.png. (Show Details)
tomek accepted this revision.Dec 6 2022, 8:41 AM

It might be a good idea to see what happens when someone else reacts when an overlay is visible.

atul accepted this revision.Dec 7 2022, 12:01 PM
This revision is now accepted and ready to land.Dec 7 2022, 12:01 PM
ginsu mentioned this in D5812: [native] introduced reactions to chat item height measurer.Dec 12 2022, 8:33 PM
ginsu abandoned this revision.Dec 12 2022, 8:35 PM

Abandoning because merged this diff with D5812

Revision Contents
Changeset List

PathSize
native/
chat/
2 lines
4 lines

Diff 19157

View Options

native/chat/multimedia-message-utils.js

use clap::{Parser, Subcommand}; use clap::{Parser, Subcommand};
use database::DatabaseClient;
use rusoto_core::Region;
use tonic::transport::Server; use tonic::transport::Server;
use tracing_subscriber::FmtSubscriber; use tracing_subscriber::FmtSubscriber;
mod config; mod config;
mod database;
mod keygen; mod keygen;
mod opaque; mod opaque;
mod service; mod service;
use config::Config; use config::Config;
use keygen::generate_and_persist_keypair; use keygen::generate_and_persist_keypair;
use service::{IdentityServiceServer, MyIdentityService}; use service::{IdentityServiceServer, MyIdentityService};
Show All 27 Linesasync fn main() -> Result<(), Box<dyn std::error::Error>> {
let cli = Cli::parse(); let cli = Cli::parse();
match &cli.command { match &cli.command {
Commands::Keygen { dir } => { Commands::Keygen { dir } => {
generate_and_persist_keypair(dir)?; generate_and_persist_keypair(dir)?;
} }
Commands::Server => { Commands::Server => {
let addr = IDENTITY_SERVICE_SOCKET_ADDR.parse()?; let addr = IDENTITY_SERVICE_SOCKET_ADDR.parse()?;
let config = Config::load()?; let config = Config::load()?;
let identity_service = MyIdentityService::new(config); let database_client = DatabaseClient::new(Region::UsEast2);
let identity_service = MyIdentityService::new(config, database_client);
Server::builder() Server::builder()
.add_service(IdentityServiceServer::new(identity_service)) .add_service(IdentityServiceServer::new(identity_service))
.serve(addr) .serve(addr)
.await?; .await?;
} }
} }
Ok(()) Ok(())
} }
View Options

native/chat/utils.js

use clap::{Parser, Subcommand}; use clap::{Parser, Subcommand};
use database::DatabaseClient;
use rusoto_core::Region;
use tonic::transport::Server; use tonic::transport::Server;
use tracing_subscriber::FmtSubscriber; use tracing_subscriber::FmtSubscriber;
mod config; mod config;
mod database;
mod keygen; mod keygen;
mod opaque; mod opaque;
mod service; mod service;
use config::Config; use config::Config;
use keygen::generate_and_persist_keypair; use keygen::generate_and_persist_keypair;
use service::{IdentityServiceServer, MyIdentityService}; use service::{IdentityServiceServer, MyIdentityService};
Show All 27 Linesasync fn main() -> Result<(), Box<dyn std::error::Error>> {
let cli = Cli::parse(); let cli = Cli::parse();
match &cli.command { match &cli.command {
Commands::Keygen { dir } => { Commands::Keygen { dir } => {
generate_and_persist_keypair(dir)?; generate_and_persist_keypair(dir)?;
} }
Commands::Server => { Commands::Server => {
let addr = IDENTITY_SERVICE_SOCKET_ADDR.parse()?; let addr = IDENTITY_SERVICE_SOCKET_ADDR.parse()?;
let config = Config::load()?; let config = Config::load()?;
let identity_service = MyIdentityService::new(config); let database_client = DatabaseClient::new(Region::UsEast2);
let identity_service = MyIdentityService::new(config, database_client);
Server::builder() Server::builder()
.add_service(IdentityServiceServer::new(identity_service)) .add_service(IdentityServiceServer::new(identity_service))
.serve(addr) .serve(addr)
.await?; .await?;
} }
} }
Ok(()) Ok(())
} }