Page MenuHomePhabricator

[keyserver] introduce sendReactionMessageRequestInputValidator to message responders
AbandonedPublic

Authored by ginsu on Nov 28 2022, 4:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 28, 7:32 AM
Unknown Object (File)
Oct 2 2024, 2:54 PM
Unknown Object (File)
Sep 28 2024, 10:59 AM
Unknown Object (File)
Sep 28 2024, 10:59 AM
Unknown Object (File)
Sep 28 2024, 10:53 AM
Unknown Object (File)
Sep 24 2024, 11:29 AM
Unknown Object (File)
Sep 5 2024, 8:18 AM
Unknown Object (File)
Sep 5 2024, 8:18 AM
Subscribers

Details

Summary

introduce sendReactionMessageRequestInputValidator to message responders. This will be used to validate the input in reactionMessageCreationResponder (which will be introduced in the subsequent diff)


Linear Task: ENG-2250

Test Plan

This will be tested in subsequent diffs. Also ran web/mobile app locally and nothing crashes/any regressions

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu edited the summary of this revision. (Show Details)
ginsu added reviewers: atul, rohan, tomek.
ginsu requested review of this revision.Nov 28 2022, 4:38 PM
ashoat requested changes to this revision.Nov 28 2022, 7:01 PM

What's the Flow type that this corresponds to? I think this would be easier to review if you combined it with the next diff. The ESLint error should be a hint

This revision now requires changes to proceed.Nov 28 2022, 7:01 PM

abandoning because D5749 handles this now