[keyserver] introduce sendReactionMessageRequestInputValidator to message responders
AbandonedPublic
Actions

Authored by ginsu on Nov 28 2022, 4:27 PM.

Details

Reviewers

atul
rohan
tomek
ashoat

Summary

introduce sendReactionMessageRequestInputValidator to message responders. This will be used to validate the input in reactionMessageCreationResponder (which will be introduced in the subsequent diff)

Linear Task: ENG-2250

Test Plan

This will be tested in subsequent diffs. Also ran web/mobile app locally and nothing crashes/any regressions

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Nov 28 2022, 4:27 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptNov 28 2022, 4:27 PM

ginsu edited the summary of this revision. (Show Details)Nov 28 2022, 4:28 PM

ginsu edited the summary of this revision. (Show Details)

ginsu edited the summary of this revision. (Show Details)Nov 28 2022, 4:33 PM

ginsu added reviewers: atul, rohan, tomek.

Harbormaster completed remote builds in B13811: Diff 18903.Nov 28 2022, 4:38 PM

ginsu requested review of this revision.Nov 28 2022, 4:38 PM

ginsu added a child revision: D5749: [keyserver] introduced reactionMessageCreationResponder function to message responders.Nov 28 2022, 4:38 PM

What's the Flow type that this corresponds to? I think this would be easier to review if you combined it with the next diff. The ESLint error should be a hint

This revision now requires changes to proceed.Nov 28 2022, 7:01 PM

abandoning because D5749 handles this now

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

message-responders.js

7 lines

Diff 18903

View Options

keyserver/src/responders/message-responders.js

Show First 20 Lines • Show All 111 Lines • ▼ Show 20 Lines	std::string AwsS3Bucket::getObjectData(const std::string &objectName) const {
Aws::S3::Model::GetObjectOutcome outcome = getS3Client()->GetObject(request);		Aws::S3::Model::GetObjectOutcome outcome = getS3Client()->GetObject(request);

if (!outcome.IsSuccess()) {		if (!outcome.IsSuccess()) {
throw std::runtime_error(outcome.GetError().GetMessage());		throw std::runtime_error(outcome.GetError().GetMessage());
}		}

Aws::IOStream &retrievedFile = outcome.GetResultWithOwnership().GetBody();		Aws::IOStream &retrievedFile = outcome.GetResultWithOwnership().GetBody();

std::string result;		std::stringstream buffer;
result.resize(size);		buffer << retrievedFile.rdbuf();
retrievedFile.get((char *)result.data(), size + 1);		std::string result(buffer.str());
		std::string cpy = result;

return result;		return result;
}		}

void AwsS3Bucket::getObjectDataChunks(		void AwsS3Bucket::getObjectDataChunks(
const std::string &objectName,		const std::string &objectName,
const std::function<void(const std::string &)> &callback,		const std::function<void(const std::string &)> &callback,
const size_t chunkSize) const {		const size_t chunkSize) const {
Show All 16 Lines	for (size_t offset = 0; offset < fileSize; offset += chunkSize) {
Aws::S3::Model::GetObjectOutcome getOutcome =		Aws::S3::Model::GetObjectOutcome getOutcome =
getS3Client()->GetObject(request);		getS3Client()->GetObject(request);
if (!getOutcome.IsSuccess()) {		if (!getOutcome.IsSuccess()) {
throw std::runtime_error(getOutcome.GetError().GetMessage());		throw std::runtime_error(getOutcome.GetError().GetMessage());
}		}

Aws::IOStream &retrievedFile =		Aws::IOStream &retrievedFile =
getOutcome.GetResultWithOwnership().GetBody();		getOutcome.GetResultWithOwnership().GetBody();
std::string result;
		std::stringstream buffer;
		buffer << retrievedFile.rdbuf();
		std::string result(buffer.str());
result.resize(nextSize);		result.resize(nextSize);
retrievedFile.get((char *)result.data(), nextSize + 1);
callback(result);		callback(result);
}		}
}		}

void AwsS3Bucket::appendToObject(		void AwsS3Bucket::appendToObject(
const std::string &objectName,		const std::string &objectName,
const std::string &data) {		const std::string &data) {
const size_t objectSize = this->getObjectSize(objectName);		const size_t objectSize = this->getObjectSize(objectName);
▲ Show 20 Lines • Show All 55 Lines • Show Last 20 Lines

[keyserver] introduce sendReactionMessageRequestInputValidator to message respondersAbandonedPublicActions