Paths

Table of Contentst

-
lib/shared/messages/
-
shared/
-
messages/
-
reaction-message-spec.js

[lib] introduced notificationTexts function to reaction message spec
ClosedPublic
Actions

Authored by ginsu on Dec 14 2022, 1:05 PM.

Details

Reviewers

tomek
rohan
ashoat

Commits

rCOMM2fcae7f1388d: [lib] introduced notificationTexts function to reaction message spec

Summary

introduced notificationTexts function to reaction message spec. Keeping the notification text generic for now with "user liked a message" and "user unlike a message", but will put up a follow up task to further improve the notification text because what I mention below is a bit out of the scope for the first version of message liking

Only send a notification if the user adds a like/reaction
Rescind a reaction notif and don't show anything new if the user removes a like/reaction
only the user who sent the target message gets a notification

Depends on D5690
Linear Task: ENG-2245

Test Plan

Please watch the demo video to see the changes I made

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 14 2022, 1:05 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 14 2022, 1:05 PM

ginsu edited the summary of this revision. (Show Details)Dec 14 2022, 1:16 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, tomek, rohan.

ginsu added parent revisions: D5854: [native] toggle reaction action in onPressReact function, D5690: [lib] introduced reaction message spec boilerplate.

ginsu attached a referenced file: F285333: Screen Recording 2022-12-14 at 3.56.32 PM.mov. (Show Details)

Harbormaster completed remote builds in B14154: Diff 19355.Dec 14 2022, 1:17 PM

ginsu requested review of this revision.Dec 14 2022, 1:17 PM

ginsu added a child revision: D5871: [lib] introduce notificationCollapseKey function to reaction message spec.Dec 14 2022, 2:11 PM

tomek accepted this revision.Dec 15 2022, 6:25 AM

tomek edited reviewers, added: ashoat; removed: atul.

ashoat accepted this revision.Dec 15 2022, 7:17 AM

This revision is now accepted and ready to land.Dec 15 2022, 7:17 AM

ginsu edited the summary of this revision. (Show Details)Dec 15 2022, 1:35 PM

ginsu removed a parent revision: D5854: [native] toggle reaction action in onPressReact function.Dec 15 2022, 1:39 PM

Closed by commit rCOMM2fcae7f1388d: [lib] introduced notificationTexts function to reaction message spec (authored by ginsu). · Explain WhyDec 15 2022, 1:40 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM2fcae7f1388d: [lib] introduced notificationTexts function to reaction message spec.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

reaction-message-spec.js

47 lines

Diff 19417

View Options

lib/shared/messages/reaction-message-spec.js

Show All 23 Lines	import {
useDispatchActionPromise,		useDispatchActionPromise,
} from '../utils/action-utils.js';		} from '../utils/action-utils.js';

const notFriendNotice = 'not friend';		const notFriendNotice = 'not friend';

function getPotentialMemberItems(		function getPotentialMemberItems(
text: string,		text: string,
userInfos: { +[id: string]: AccountUserInfo },		userInfos: { +[id: string]: AccountUserInfo },
searchIndex: SearchIndex,		inputSearchIndex: SearchIndex \| $ReadOnlyArray<SearchIndex>,
excludeUserIDs: $ReadOnlyArray<string>,		excludeUserIDs: $ReadOnlyArray<string>,
inputParentThreadInfo: ?ThreadInfo,		inputParentThreadInfo: ?ThreadInfo,
inputCommunityThreadInfo: ?ThreadInfo,		inputCommunityThreadInfo: ?ThreadInfo,
threadType: ?ThreadType,		threadType: ?ThreadType,
): UserListItem[] {		): UserListItem[] {
		const searchIndexes = Array.isArray(inputSearchIndex)
		? inputSearchIndex
		: [inputSearchIndex];

const communityThreadInfo =		const communityThreadInfo =
inputCommunityThreadInfo && inputCommunityThreadInfo.id !== genesis.id		inputCommunityThreadInfo && inputCommunityThreadInfo.id !== genesis.id
? inputCommunityThreadInfo		? inputCommunityThreadInfo
: null;		: null;
const parentThreadInfo =		const parentThreadInfo =
inputParentThreadInfo && inputParentThreadInfo.id !== genesis.id		inputParentThreadInfo && inputParentThreadInfo.id !== genesis.id
? inputParentThreadInfo		? inputParentThreadInfo
: null;		: null;
Show All 10 Lines	): UserListItem[] {
}		}

let results = [];		let results = [];
const appendUserInfo = (userInfo: AccountUserInfo) => {		const appendUserInfo = (userInfo: AccountUserInfo) => {
const { id } = userInfo;		const { id } = userInfo;
if (excludeUserIDs.includes(id)) {		if (excludeUserIDs.includes(id)) {
return;		return;
}		}
		if (results.some(item => item.id === id)) {
		return;
		}
if (		if (
communityThreadInfo &&		communityThreadInfo &&
!threadMemberHasPermission(		!threadMemberHasPermission(
communityThreadInfo,		communityThreadInfo,
id,		id,
threadPermissions.KNOW_OF,		threadPermissions.KNOW_OF,
)		)
) {		) {
return;		return;
}		}
results.push({		results.push({
...userInfo,		...userInfo,
isMemberOfParentThread: userIsMember(parentThreadInfo, id),		isMemberOfParentThread: userIsMember(parentThreadInfo, id),
isMemberOfContainingThread: userIsMember(containingThreadInfo, id),		isMemberOfContainingThread: userIsMember(containingThreadInfo, id),
});		});
};		};
if (text === '') {		if (text === '') {
for (const id in userInfos) {		for (const id in userInfos) {
appendUserInfo(userInfos[id]);		appendUserInfo(userInfos[id]);
}		}
} else {		} else {
		for (const searchIndex of searchIndexes) {
const ids = searchIndex.getSearchResults(text);		const ids = searchIndex.getSearchResults(text);
for (const id of ids) {		for (const id of ids) {
appendUserInfo(userInfos[id]);		appendUserInfo(userInfos[id]);
}		}
}		}
		}

const blockedRelationshipsStatuses = new Set([		const blockedRelationshipsStatuses = new Set([
userRelationshipStatus.BLOCKED_BY_VIEWER,		userRelationshipStatus.BLOCKED_BY_VIEWER,
userRelationshipStatus.BLOCKED_VIEWER,		userRelationshipStatus.BLOCKED_VIEWER,
userRelationshipStatus.BOTH_BLOCKED,		userRelationshipStatus.BOTH_BLOCKED,
]);		]);

if (text === '') {		if (text === '') {
▲ Show 20 Lines • Show All 119 Lines • Show Last 20 Lines

[lib] introduced notificationTexts function to reaction message specClosedPublicActions