Page MenuHomePhabricator
Differential D5870

[lib] introduced notificationTexts function to reaction message spec
ClosedPublic
Actions

Authored by ginsu on Dec 14 2022, 1:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 9:21 PM
Unknown Object (File)
Mon, Mar 17, 9:21 PM
Unknown Object (File)
Mon, Mar 17, 9:20 PM
Unknown Object (File)
Mon, Mar 17, 9:11 PM
Unknown Object (File)
Wed, Feb 19, 7:06 PM
Unknown Object (File)
Feb 13 2025, 10:29 PM
Unknown Object (File)
Feb 13 2025, 10:29 PM
Unknown Object (File)
Feb 13 2025, 10:29 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
tomek
rohan
ashoat
Commits
rCOMM2fcae7f1388d: [lib] introduced notificationTexts function to reaction message spec
Summary

introduced notificationTexts function to reaction message spec. Keeping the notification text generic for now with "user liked a message" and "user unlike a message", but will put up a follow up task to further improve the notification text because what I mention below is a bit out of the scope for the first version of message liking

  1. Only send a notification if the user adds a like/reaction
  2. Rescind a reaction notif and don't show anything new if the user removes a like/reaction
  3. only the user who sent the target message gets a notification

Depends on D5690
Linear Task: ENG-2245

Test Plan

Please watch the demo video to see the changes I made

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 14 2022, 1:05 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 14 2022, 1:05 PM
ginsu edited the summary of this revision. (Show Details)Dec 14 2022, 1:16 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, tomek, rohan.
ginsu added parent revisions: D5854: [native] toggle reaction action in onPressReact function, D5690: [lib] introduced reaction message spec boilerplate.
ginsu attached a referenced file: F285333: Screen Recording 2022-12-14 at 3.56.32 PM.mov. (Show Details)
Harbormaster completed remote builds in B14154: Diff 19355.Dec 14 2022, 1:17 PM
ginsu requested review of this revision.Dec 14 2022, 1:17 PM
ginsu added a child revision: D5871: [lib] introduce notificationCollapseKey function to reaction message spec.Dec 14 2022, 2:11 PM
tomek accepted this revision.Dec 15 2022, 6:25 AM
tomek edited reviewers, added: ashoat; removed: atul.
ashoat accepted this revision.Dec 15 2022, 7:17 AM
This revision is now accepted and ready to land.Dec 15 2022, 7:17 AM
ginsu edited the summary of this revision. (Show Details)Dec 15 2022, 1:35 PM
ginsu removed a parent revision: D5854: [native] toggle reaction action in onPressReact function.Dec 15 2022, 1:39 PM
Closed by commit rCOMM2fcae7f1388d: [lib] introduced notificationTexts function to reaction message spec (authored by ginsu). · Explain WhyDec 15 2022, 1:40 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM2fcae7f1388d: [lib] introduced notificationTexts function to reaction message spec.

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
47 lines

Diff 19417

View Options

lib/shared/messages/reaction-message-spec.js

Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Linesconst light = Object.freeze({
drawerItemLabelLevel0: '#0A0A0A', drawerItemLabelLevel0: '#0A0A0A',
drawerItemLabelLevel1: '#0A0A0A', drawerItemLabelLevel1: '#0A0A0A',
drawerItemLabelLevel2: '#1F1F1F', drawerItemLabelLevel2: '#1F1F1F',
drawerOpenCommunityBackground: '#F5F5F5', drawerOpenCommunityBackground: '#F5F5F5',
drawerBackground: '#FFFFFF', drawerBackground: '#FFFFFF',
subthreadsModalClose: '#808080', subthreadsModalClose: '#808080',
subthreadsModalBackground: '#EBEBEB', subthreadsModalBackground: '#EBEBEB',
subthreadsModalSearch: '#00000008', subthreadsModalSearch: '#00000008',
messageLabel: '#0A0A0A',
}); });
export type Colors = $Exact<typeof light>; export type Colors = $Exact<typeof light>;
const dark: Colors = Object.freeze({ const dark: Colors = Object.freeze({
blockQuoteBackground: '#A9A9A9', blockQuoteBackground: '#A9A9A9',
blockQuoteBorder: '#808080', blockQuoteBorder: '#808080',
codeBackground: '#0A0A0A', codeBackground: '#0A0A0A',
disabledButton: '#404040', disabledButton: '#404040',
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Linesconst dark: Colors = Object.freeze({
drawerOpenCommunityBackground: '#191919', drawerOpenCommunityBackground: '#191919',
drawerBackground: '#1F1F1F', drawerBackground: '#1F1F1F',
subthreadsModalClose: '#808080', subthreadsModalClose: '#808080',
subthreadsModalBackground: '#1F1F1F', subthreadsModalBackground: '#1F1F1F',
subthreadsModalSearch: '#FFFFFF04', subthreadsModalSearch: '#FFFFFF04',
typeaheadTooltipBackground: '#1F1F1f', typeaheadTooltipBackground: '#1F1F1f',
typeaheadTooltipBorder: '#404040', typeaheadTooltipBorder: '#404040',
typeaheadTooltipText: 'white', typeaheadTooltipText: 'white',
messageLabel: '#CCCCCC',
}); });
const colors = { light, dark }; const colors = { light, dark };
const colorsSelector: (state: AppState) => Colors = createSelector( const colorsSelector: (state: AppState) => Colors = createSelector(
(state: AppState) => state.globalThemeInfo.activeTheme, (state: AppState) => state.globalThemeInfo.activeTheme,
(theme: ?GlobalTheme) => { (theme: ?GlobalTheme) => {
const explicitTheme = theme ? theme : 'light'; const explicitTheme = theme ? theme : 'light';
return colors[explicitTheme]; return colors[explicitTheme];
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines