Page MenuHomePhabricator

[lib] introduced notificationTexts function to reaction message spec
ClosedPublic

Authored by ginsu on Dec 14 2022, 1:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 5, 1:26 AM
Unknown Object (File)
Sun, May 5, 1:26 AM
Unknown Object (File)
Sun, May 5, 12:52 AM
Unknown Object (File)
Mar 28 2024, 1:05 AM
Unknown Object (File)
Mar 28 2024, 1:05 AM
Unknown Object (File)
Mar 28 2024, 1:04 AM
Unknown Object (File)
Mar 28 2024, 12:55 AM
Unknown Object (File)
Mar 11 2024, 9:36 PM
Subscribers

Details

Summary

introduced notificationTexts function to reaction message spec. Keeping the notification text generic for now with "user liked a message" and "user unlike a message", but will put up a follow up task to further improve the notification text because what I mention below is a bit out of the scope for the first version of message liking

  1. Only send a notification if the user adds a like/reaction
  2. Rescind a reaction notif and don't show anything new if the user removes a like/reaction
  3. only the user who sent the target message gets a notification

Depends on D5690
Linear Task: ENG-2245

Test Plan

Please watch the demo video to see the changes I made

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.Dec 14 2022, 1:17 PM
tomek edited reviewers, added: ashoat; removed: atul.
This revision is now accepted and ready to land.Dec 15 2022, 7:17 AM