Page MenuHomePhabricator
Differential D5998

[native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies
AbandonedPublic
Actions

Authored by varun on Dec 22 2022, 7:07 AM.
Tags
None
Referenced Files
F3492616: D5998.diff
Thu, Dec 19, 12:50 AM
F3491017: D5998.id20575.diff
Wed, Dec 18, 6:16 PM
F3491012: D5998.id20581.diff
Wed, Dec 18, 6:16 PM
F3491011: D5998.id20251.diff
Wed, Dec 18, 6:16 PM
F3490819: D5998.id20028.diff
Wed, Dec 18, 5:34 PM
F3490818: D5998.id20025.diff
Wed, Dec 18, 5:34 PM
F3488660: D5998.id.diff
Wed, Dec 18, 10:59 AM
Unknown Object (File)
Sat, Dec 7, 11:15 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• jon
ashoat
• max
Commits
rCOMMa5ec4c770533: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies
rCOMMd2fd0f2e9fba: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies
Summary

This diff introduces adding the following Rust dependencies:

  • OpenSSL: We need the OpenSSL crate for the signing capabilities in D5999. We are using vendored OpenSSL, in this case, the system OpenSSL library will be used (linked).
  • Base64: We are passing and getting the signed string from and to the Tunnelbroker in the Base64 format. The dependency is used in D5999.
  • Anyhow: We are using this crate to pass errors to the function caller easily. First, this crate is used in D5999.

Linear task: ENG-1333

Test Plan

All CI gates are passed.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.Dec 22 2022, 7:07 AM
• max held this revision as a draft.
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 22 2022, 7:07 AM
Harbormaster failed remote builds in B14685: Diff 20025!Dec 22 2022, 7:11 AM
• max added a child revision: D5999: [native/rust_library] Adding `sign_string_with_private_key` function to crypto tools.Dec 22 2022, 7:13 AM
• max updated this revision to Diff 20028.Dec 22 2022, 7:47 AM

Move OpenSSL to be vendored.

• max edited the summary of this revision. (Show Details)Dec 22 2022, 8:00 AM
• max edited the test plan for this revision. (Show Details)
• max added reviewers: • jon, varun.
Harbormaster completed remote builds in B14688: Diff 20028.Dec 22 2022, 8:00 AM
• max published this revision for review.Dec 22 2022, 8:03 AM
ashoat mentioned this in D5926: [services/commtest] Adding of openssl, base64, anyhow to dependencies.Dec 22 2022, 8:05 AM
varun accepted this revision.Dec 22 2022, 10:41 PM
• jon accepted this revision.Dec 23 2022, 2:30 PM
This revision is now accepted and ready to land.Dec 23 2022, 2:30 PM
• max added a reviewer: ashoat.Dec 28 2022, 7:26 AM
This revision now requires review to proceed.Dec 28 2022, 7:26 AM
• max added a comment.Dec 28 2022, 7:27 AM

Adding @ashoat for a final pass.

ashoat accepted this revision.Dec 28 2022, 8:59 AM
This revision is now accepted and ready to land.Dec 28 2022, 8:59 AM
Closed by commit rCOMMd2fd0f2e9fba: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies (authored by • max). · Explain WhyDec 28 2022, 10:36 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMMd2fd0f2e9fba: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies.
ashoat added a reverting change: D6079: Revert "[native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies".Dec 28 2022, 7:28 PM
ashoat added a reverting change: rCOMM3aa996ec84f7: Revert "[native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies".Dec 28 2022, 7:46 PM
ashoat added a comment.Dec 28 2022, 7:49 PM

Interesting that this passed CI given it broke Android build

atul added a comment.Dec 28 2022, 7:56 PM

We use scripts/install_protobuf.sh to install v3.15.8 on the Buildkite agents. We should do the same thing for the GitHub runners instead of apt-get install -y protobuf-compiler.

• max reopened this revision.Dec 29 2022, 2:47 AM
This revision is now accepted and ready to land.Dec 29 2022, 2:47 AM
• max added a comment.EditedDec 29 2022, 2:50 AM

This diff will be landed after ENG-2563 will be resolved.

• max updated this revision to Diff 20575.Jan 4 2023, 7:12 AM

Rebasing on master changes.

Harbormaster completed remote builds in B15084: Diff 20575.Jan 4 2023, 7:26 AM
Closed by commit rCOMMa5ec4c770533: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies (authored by • max). · Explain WhyJan 4 2023, 9:39 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMMa5ec4c770533: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies.
• max added a reverting change: D6173: [native/rust_library] Revert: Adding `openssl`, `base64`, `anyhow` dependencies".Jan 5 2023, 1:42 AM
• max reopened this revision.Jan 12 2023, 8:29 AM

I'll reopen this diff, but it will not be landed until the Rust OpenSSL problem on native will be resolved or we will replace the verifying function in D5999 without using OpenSSL. In this case, it will be abandoned, but for now it's better to keep it open to not to forget the state of the stack.

This revision is now accepted and ready to land.Jan 12 2023, 8:29 AM
ashoat added a comment.Jan 12 2023, 2:54 PM

Strongly recommend avoiding OpenSSL here

varun commandeered this revision.Jan 15 2024, 12:45 PM
varun abandoned this revision.
varun edited reviewers, added: • max; removed: varun.

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
3 lines

Diff 20251

View Options

native/native_rust_library/Cargo.lock

Loading...
View Options

native/native_rust_library/Cargo.toml

Loading...