Page MenuHomePhabricator
Differential D6041

[web] Keyboard support for typeahead [1/13] - Moved getTypeaheadUserSuggestions to lib
ClosedPublic
Actions

Authored by • przemek on Dec 27 2022, 4:31 AM.
Tags
None
Referenced Files
F3352782: D6041.id20859.diff
Sat, Nov 23, 7:08 AM
Unknown Object (File)
Wed, Nov 13, 5:23 AM
Unknown Object (File)
Tue, Nov 5, 4:24 AM
Unknown Object (File)
Tue, Nov 5, 4:24 AM
Unknown Object (File)
Mon, Nov 4, 1:19 AM
Unknown Object (File)
Fri, Nov 1, 10:45 AM
Unknown Object (File)
Mon, Oct 28, 8:29 AM
Unknown Object (File)
Oct 7 2024, 3:35 AM
View All Files
Subscribers
ashoat
atul
ginsu
inka
kamil
tomek

Details

Reviewers
inka
kamil
ginsu
tomek
Commits
rCOMM15354950eecb: [web] Keyboard support for typeahead [1/13] - Moved getTypeaheadUserSuggestions…
Summary

Moved function that will be common for web and native to lib

Test Plan

Typeahead without keyboard support works.
Final tests performed in last diffs.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• przemek created this revision.Dec 27 2022, 4:31 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptDec 27 2022, 4:31 AM
Harbormaster completed remote builds in B14774: Diff 20152.Dec 27 2022, 4:46 AM
• przemek requested review of this revision.Dec 27 2022, 4:46 AM
• przemek added a parent revision: D5819: [web] Add other <button> props to Button..Dec 27 2022, 5:30 AM
• przemek added a child revision: D6042: [web] Keyboard support for typeahead [2/13] - Moved typeahead-utils.js.
ginsu accepted this revision.Dec 27 2022, 3:38 PM
This revision is now accepted and ready to land.Dec 27 2022, 3:38 PM
• przemek added a reviewer: tomek.Dec 29 2022, 11:55 AM
This revision now requires review to proceed.Dec 29 2022, 11:55 AM
tomek accepted this revision.Dec 30 2022, 6:42 AM
This revision is now accepted and ready to land.Dec 30 2022, 6:42 AM
• przemek updated this revision to Diff 20852.Jan 12 2023, 1:54 AM

rebase

Harbormaster completed remote builds in B15290: Diff 20852.Jan 12 2023, 2:07 AM
Closed by commit rCOMM15354950eecb: [web] Keyboard support for typeahead [1/13] - Moved getTypeaheadUserSuggestions… (authored by • przemek). · Explain WhyJan 12 2023, 6:18 AM
This revision was automatically updated to reflect the committed changes.
• przemek added a commit: rCOMM15354950eecb: [web] Keyboard support for typeahead [1/13] - Moved getTypeaheadUserSuggestions….

Revision Contents
Changeset List

PathSize
lib/
shared/
21 lines
web/
chat/
2 lines
16 lines

Diff 20859

View Options

lib/shared/typeahead-utils.js

Loading...
View Options

web/chat/typeahead-tooltip.react.js

Loading...
View Options

web/chat/typeahead-utils.js

Loading...