Page MenuHomePhabricator
Differential D6042

[web] Keyboard support for typeahead [2/13] - Moved typeahead-utils.js
ClosedPublic
Actions

Authored by • przemek on Dec 27 2022, 4:34 AM.
Tags
None
Referenced Files
F1786447: D6042.diff
Sat, May 18, 4:58 PM
Unknown Object (File)
Fri, May 3, 3:17 AM
Unknown Object (File)
Apr 10 2024, 4:55 PM
Unknown Object (File)
Apr 9 2024, 2:42 AM
Unknown Object (File)
Apr 9 2024, 2:42 AM
Unknown Object (File)
Apr 3 2024, 5:53 PM
Unknown Object (File)
Mar 13 2024, 8:53 PM
Unknown Object (File)
Mar 7 2024, 7:16 AM
View All 45 Files
Subscribers
ashoat
atul
ginsu
inka
kamil
tomek

Details

Reviewers
inka
kamil
ginsu
tomek
Commits
rCOMM9c267823c49b: [web] Keyboard support for typeahead [2/13] - Moved typeahead-utils.js
Summary

Moved utility functions to web/utils.

Test Plan

Typeahead without keyboard support works.
Final tests performed in last diffs.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• przemek created this revision.Dec 27 2022, 4:34 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptDec 27 2022, 4:34 AM
Harbormaster completed remote builds in B14775: Diff 20153.Dec 27 2022, 4:47 AM
• przemek requested review of this revision.Dec 27 2022, 4:47 AM
• przemek added a parent revision: D6041: [web] Keyboard support for typeahead [1/13] - Moved getTypeaheadUserSuggestions to lib.Dec 27 2022, 5:30 AM
• przemek added a child revision: D6043: [web] Keyboard support for typeahead [3/13] - Renamed animation state.
ginsu accepted this revision.Dec 27 2022, 3:41 PM
This revision is now accepted and ready to land.Dec 27 2022, 3:41 PM
• przemek added a reviewer: tomek.Dec 29 2022, 11:55 AM
This revision now requires review to proceed.Dec 29 2022, 11:55 AM
tomek accepted this revision.Dec 30 2022, 7:07 AM
This revision is now accepted and ready to land.Dec 30 2022, 7:07 AM
Closed by commit rCOMM9c267823c49b: [web] Keyboard support for typeahead [2/13] - Moved typeahead-utils.js (authored by • przemek). · Explain WhyJan 12 2023, 6:21 AM
This revision was automatically updated to reflect the committed changes.
• przemek added a commit: rCOMM9c267823c49b: [web] Keyboard support for typeahead [2/13] - Moved typeahead-utils.js.

Revision Contents
Changeset List

Diff 20860

View Options

web/chat/chat-input-bar.react.js

Loading...
View Options

web/chat/typeahead-tooltip.react.js

Loading...
View Options

web/chat/typeahead-utils.js

Loading...
View Options

web/utils/typeahead-utils.js

Loading...