Paths

Table of Contentst

Differential D6046

[web] Keyboard support for typeahead [6/13] - Get rid of entire text and rename matched strings
ClosedPublic
Actions

Authored by • przemek on Dec 27 2022, 4:49 AM.

Tags

None

Referenced Files

	F1695294: D6046.diff
	Fri, May 3, 4:03 AM

	F1695244: D6046.diff
	Fri, May 3, 3:16 AM

	Unknown Object (File)
	Wed, Apr 3, 4:14 PM

	Unknown Object (File)
	Wed, Apr 3, 4:14 PM

	Unknown Object (File)
	Wed, Apr 3, 4:12 PM

	Unknown Object (File)
	Mar 29 2024, 12:38 AM

	Unknown Object (File)
	Mar 13 2024, 8:53 PM

	Unknown Object (File)
	Mar 7 2024, 3:54 AM

View All 49 Files

Subscribers

Details

Reviewers

inka
kamil
ginsu
tomek

Commits

rCOMM6994060d445e: [web] Keyboard support for typeahead [6/13] - Get rid of entire text and rename…

Summary

Some renaming of arguments and variables.
Removed entireText from TypeaheadMatchedStrings as we only needed its length in getTypeaheadTooltipActions function.
Length of entire text can be easily obtained by textBeforeAtSymbol.length + usernamePrefix.length + 1 where 1 stands for @ symbol.

Test Plan

Typeahead without keyboard support works.
Final tests performed in last diffs.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• przemek created this revision.Dec 27 2022, 4:49 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptDec 27 2022, 4:49 AM

Harbormaster completed remote builds in B14779: Diff 20157.Dec 27 2022, 5:03 AM

• przemek requested review of this revision.Dec 27 2022, 5:03 AM

• przemek added a parent revision: D6045: [web] Keyboard support for typeahead [5/13] - Moved finding suggested users out of tooltip component.Dec 27 2022, 5:31 AM

• przemek added a child revision: D6047: [web] Keyboard support for typeahead [7/13] - Refactor getTypeaheadTooltipActions using params as argument.

inka accepted this revision.Dec 28 2022, 5:58 AM

inka added a reviewer: tomek.

tomek accepted this revision.Dec 30 2022, 8:43 AM

This revision is now accepted and ready to land.Dec 30 2022, 8:43 AM

Closed by commit rCOMM6994060d445e: [web] Keyboard support for typeahead [6/13] - Get rid of entire text and rename… (authored by • przemek). · Explain WhyJan 12 2023, 6:21 AM

This revision was automatically updated to reflect the committed changes.

• przemek added a commit: rCOMM6994060d445e: [web] Keyboard support for typeahead [6/13] - Get rid of entire text and rename….

Revision Contents
Changeset List

Path

Size

lib/

shared/

typeahead-utils.js

8 lines

web/

chat/

chat-input-bar.react.js

2 lines

typeahead-tooltip.react.js

27 lines

utils/

typeahead-utils.js

15 lines

Diff 20157

lib/shared/typeahead-utils.js

Loading...

web/chat/chat-input-bar.react.js

Loading...

web/chat/typeahead-tooltip.react.js

Loading...

web/utils/typeahead-utils.js

Loading...