Page MenuHomePhabricator

[web] Add community drawer to CommunityPicker
ClosedPublic

Authored by inka on Jan 4 2023, 8:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 2:01 PM
Unknown Object (File)
Sun, Mar 3, 3:48 AM
Unknown Object (File)
Sat, Mar 2, 5:58 PM
Unknown Object (File)
Sat, Mar 2, 5:58 PM
Unknown Object (File)
Sat, Mar 2, 5:58 PM
Unknown Object (File)
Sat, Mar 2, 5:58 PM
Unknown Object (File)
Sat, Mar 2, 5:58 PM
Unknown Object (File)
Sat, Mar 2, 5:58 PM
Subscribers

Details

Summary

linear issue: https://linear.app/comm/issue/ENG-2631/drawer-sidebar-inside-of-community-picker
The designs are not done yet, so styling will be updated later on.

Test Plan

Run the web app, checked that community drawer is present in CommunityPicker and behaves as expected.

Diff Detail

Repository
rCOMM Comm
Branch
inka/community_drawer_web
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka requested review of this revision.Jan 4 2023, 9:14 AM

Fix in place community-picker width

web/sidebar/community-picker.css
27 ↗(On Diff #20582)

These could be merged.

Fix grid usage

This revision is now accepted and ready to land.Jan 26 2023, 6:17 AM
This revision now requires review to proceed.Jan 27 2023, 2:10 AM
tomek added inline comments.
web/sidebar/left-layout-aside.css
6 ↗(On Diff #21148)

Have you checked if 100% or flex: 1 work ok?

This revision is now accepted and ready to land.Jan 31 2023, 7:04 AM
web/sidebar/left-layout-aside.css
6 ↗(On Diff #21148)

This will be revisited during the styling task. I remember having some problems with the normal flex-based approach. But if you don't mind I won't change that, because this whole component actually gets deleted down the road, and all styles will be updated anyway.