Page MenuHomePhabricator
Differential D6971

[web] Filter available chats based on the picked community
ClosedPublic
Actions

Authored by inka on Mar 7 2023, 3:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 4, 10:10 PM
Unknown Object (File)
Thu, Apr 4, 10:10 PM
Unknown Object (File)
Thu, Apr 4, 10:10 PM
Unknown Object (File)
Thu, Apr 4, 10:09 PM
Unknown Object (File)
Thu, Apr 4, 10:02 PM
Unknown Object (File)
Sun, Mar 31, 7:41 PM
Unknown Object (File)
Feb 26 2024, 3:29 PM
Unknown Object (File)
Feb 21 2024, 1:52 AM
View All 50 Files
Subscribers
ashoat
atul

Details

Reviewers
kamil
tomek
michal
Commits
rCOMMb70b8c89b328: [web] Filter available chats based on the picked community
Summary

issue: https://linear.app/comm/issue/ENG-3176/make-pressing-a-drawer-item-in-chat-tab-filter-available-chats
We want the list of chats in ChatThreadList to be filtered based on the currently selected community in the Chat tab

Test Plan

Checked that if a community is set in state.pickedCommunityIDs.chat, then ChatThreadList displays only chats from that community
Checked that the Background tab also works

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Mar 7 2023, 3:06 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptMar 7 2023, 3:06 AM
inka added a parent revision: D6970: [web] Add a selector for fetching picked community in Chat tab.Mar 7 2023, 3:07 AM
inka edited the test plan for this revision. (Show Details)
inka added a child revision: D6972: [web] Make pressing Inbox button reset selected community.Mar 7 2023, 3:11 AM
Harbormaster completed remote builds in B17144: Diff 23484.Mar 7 2023, 3:21 AM
inka requested review of this revision.Mar 7 2023, 3:21 AM
kamil accepted this revision.Mar 8 2023, 3:28 AM
This revision is now accepted and ready to land.Mar 8 2023, 3:28 AM
inka updated this revision to Diff 24782.Apr 7 2023, 6:55 AM

Remove use of usePickedCommunityChat, rebase

Harbormaster completed remote builds in B18082: Diff 24782.Apr 7 2023, 7:12 AM
inka edited parent revisions, added: D6969: [web] Add to reducer logic handling community id picked in chat; removed: D6970: [web] Add a selector for fetching picked community in Chat tab.May 22 2023, 5:53 AM
Closed by commit rCOMMb70b8c89b328: [web] Filter available chats based on the picked community (authored by • InkaSokolowska). · Explain WhyMay 23 2023, 1:01 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMMb70b8c89b328: [web] Filter available chats based on the picked community.

Revision Contents
Changeset List

PathSize
web/
chat/
15 lines

Diff 24782

View Options

web/chat/chat-thread-list.react.js

Loading...