[web] Add handlers for drawer community items
ClosedPublic
Actions

Authored by inka on Mar 7 2023, 3:46 AM.

Details

Reviewers

kamil
tomek
michal

Commits

rCOMM2ae10adcfd69: [web] Add handlers for drawer community items

Summary

Adding hanndlers that will be used by the community items in the drawer
They will be used like CommunityDrawerItemHandler were used before in CommunityDrawerItem. They provide drawer community items with an onClick function, that defines how the items is
supposed to behave, an expanded boolean, that tells the community whether it is expanded, and a isActive boolean that tells whether the user has currently that exact chat selected.
issue: https://linear.app/comm/issue/ENG-3176/make-pressing-a-drawer-item-in-chat-tab-filter-available-chats

Test Plan

Tested with later diffs

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Mar 7 2023, 3:46 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptMar 7 2023, 3:46 AM

inka added a parent revision: D6973: [web] Extract from drawer item code that can be reused in community items.Mar 7 2023, 3:46 AM

inka added a child revision: D6975: [web] Add expanded and toggleExpanded to CommunityDrawerItemHandler type.Mar 7 2023, 3:51 AM

Harbormaster completed remote builds in B17147: Diff 23487.Mar 7 2023, 4:00 AM

inka requested review of this revision.Mar 7 2023, 4:00 AM

kamil mentioned this in D6970: [web] Add a selector for fetching picked community in Chat tab.Mar 8 2023, 3:09 AM

tomek accepted this revision.Mar 24 2023, 11:22 AM

tomek added inline comments.

web/sidebar/community-drawer-item-community-handlers.react.js
48	Maybe use the full name?
web/sidebar/community-drawer-item-handler.react.js
3–12	Do we have to introduce a new type? How about adding `expanded` to `CommunityDrawerItemHandler`?

This revision is now accepted and ready to land.Mar 24 2023, 11:22 AM

inka added inline comments.Apr 7 2023, 7:01 AM

web/sidebar/community-drawer-item-handler.react.js
3–12	`expanded` is added to `CommunityDrawerItemHandler` in D6975, but so is a new field - `toggleExpanded`. I prefer to have separate types for community items, which don't have this filed. It avoids the ambiguity of not knowing which items are supposed to have it defined and which are not.