[services][blob] Extract BlobItem creation
ClosedPublic
Actions

Authored by bartek on Apr 13 2023, 11:09 PM.

Details

Reviewers

marcin
michal
• jon
varun

Commits

rCOMM40bcae0f5d57: [services][blob] Extract BlobItem creation

Summary

This one was actually a starter task but I'll need this one inside HTTP server too so doing it now.

Depends on D7441

Test Plan

Blob service builds and runs. Ran integration tests to ensure items are still created correctly.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Apr 13 2023, 11:09 PM

bartek held this revision as a draft.

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 13 2023, 11:09 PM

bartek added a child revision: D7443: [services][blob] Add dependencies for HTTP server.Apr 13 2023, 11:15 PM

bartek published this revision for review.Apr 13 2023, 11:25 PM

Harbormaster completed remote builds in B18358: Diff 25152.Apr 13 2023, 11:27 PM

• jon accepted this revision.Apr 14 2023, 9:24 AM

This revision is now accepted and ready to land.Apr 14 2023, 9:24 AM

Closed by commit rCOMM40bcae0f5d57: [services][blob] Extract BlobItem creation (authored by bartek). · Explain WhyApr 19 2023, 2:10 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM40bcae0f5d57: [services][blob] Extract BlobItem creation.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

database.rs

18 lines

grpc.rs

12 lines

Diff 25152

View Options

services/blob/src/database.rs