Page MenuHomePhabricator
Differential D7825

[web] Store edited message draft in the state
ClosedPublic
Actions

Authored by • kuba on May 16 2023, 1:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 4, 8:14 AM
Unknown Object (File)
Mon, Nov 4, 8:14 AM
Unknown Object (File)
Mon, Nov 4, 8:14 AM
Unknown Object (File)
Mon, Nov 4, 8:14 AM
Unknown Object (File)
Mon, Nov 4, 8:13 AM
Unknown Object (File)
Mon, Nov 4, 8:13 AM
Unknown Object (File)
Oct 26 2024, 11:17 PM
Unknown Object (File)
Oct 26 2024, 11:17 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
michal
inka
Commits
rCOMM08991cd734c6: [web] Store edited message draft in the state
Summary

Enabled user to make changes to the text. Storing the draft in the EditState.

Test Plan

Run the app. Checked if user can edit text in the input bar. Checked if the state is updated.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• kuba created this revision.May 16 2023, 1:57 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 16 2023, 1:57 AM
• kuba added a parent revision: D7824: [web] Enter edit state after pressing edit button.May 16 2023, 1:57 AM
Harbormaster completed remote builds in B19360: Diff 26491.May 16 2023, 2:14 AM
• kuba requested review of this revision.May 16 2023, 2:14 AM
• kuba added a child revision: D7827: [web] Display edit state (in the background).May 16 2023, 3:52 AM
• kuba updated this revision to Diff 26576.May 17 2023, 3:13 AM

Rebase

Harbormaster completed remote builds in B19426: Diff 26576.May 17 2023, 3:32 AM
michal accepted this revision.May 18 2023, 4:16 AM
michal added inline comments.
web/chat/chat-input-text-area.react.js
14 ↗(On Diff #26576)

I think something like onCurrentTextChange is more descriptive

web/chat/edit-message-provider.js
55–57 ↗(On Diff #26576)

Can this happen? Should this be an invariant?

This revision is now accepted and ready to land.May 18 2023, 4:16 AM
• kuba updated this revision to Diff 26640.May 18 2023, 8:11 AM

Rebase

Harbormaster completed remote builds in B19475: Diff 26640.May 18 2023, 8:29 AM
Closed by commit rCOMM08991cd734c6: [web] Store edited message draft in the state (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyMay 24 2023, 3:47 AM
This revision was automatically updated to reflect the committed changes.
kosmydel <kukubaczek@gmail.com> added a commit: rCOMM08991cd734c6: [web] Store edited message draft in the state.

Revision Contents
Changeset List

Diff 26491

View Options

web/chat/chat-input-text-area.react.js

Loading...
View Options

web/chat/edit-message-provider.js

Loading...
View Options

web/chat/edit-text-message.react.js

Loading...