Page MenuHomePhabricator
Differential D7850

[web] Handle new messages when in edit mode
ClosedPublic
Actions

Authored by • kuba on May 17 2023, 4:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 4:06 AM
Unknown Object (File)
Wed, Dec 4, 4:06 AM
Unknown Object (File)
Wed, Dec 4, 4:06 AM
Unknown Object (File)
Tue, Dec 3, 10:55 PM
Unknown Object (File)
Tue, Dec 3, 10:55 PM
Unknown Object (File)
Tue, Dec 3, 10:55 PM
Unknown Object (File)
Nov 4 2024, 1:19 PM
Unknown Object (File)
Nov 4 2024, 1:19 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
michal
inka
Commits
rCOMMd4c7ad457a7b: [web] Handle new messages when in edit mode
Summary

If the user edits the message, and new messages appear, we want the modal to stay in place. I blocked scrolling to the bottom when the user is in the edit mode.

Test Plan
  • Opened the same thread in two browsers.
  • Entered edit mode in one.
  • Send a message from the second browser.
  • Checked if the modal stays in place.

Diff Detail

Repository
rCOMM Comm
Branch
kuba/message-editing-web
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• kuba created this revision.May 17 2023, 4:05 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 17 2023, 4:05 AM
• kuba added a parent revision: D7849: [web] Prevent user from closing the tab with unsaved edits.May 17 2023, 4:05 AM
Harbormaster completed remote builds in B19443: Diff 26593.May 17 2023, 4:22 AM
• kuba requested review of this revision.May 17 2023, 4:22 AM
michal accepted this revision.May 18 2023, 4:16 AM
This revision is now accepted and ready to land.May 18 2023, 4:16 AM
• kuba updated this revision to Diff 26648.May 18 2023, 8:14 AM

Rebase

Harbormaster completed remote builds in B19483: Diff 26648.May 18 2023, 8:48 AM
• kuba updated this revision to Diff 26821.May 23 2023, 12:45 AM

Address review

Harbormaster completed remote builds in B19625: Diff 26821.May 23 2023, 1:03 AM
• kuba added a child revision: D7930: [web] Changed edit modal overlay opacity.May 23 2023, 1:06 AM
Closed by commit rCOMMd4c7ad457a7b: [web] Handle new messages when in edit mode (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyMay 24 2023, 3:47 AM
This revision was automatically updated to reflect the committed changes.
kosmydel <kukubaczek@gmail.com> added a commit: rCOMMd4c7ad457a7b: [web] Handle new messages when in edit mode.

Revision Contents
Changeset List

PathSize
web/
chat/
11 lines

Diff 26821

View Options

web/chat/chat-message-list.react.js

Loading...