Details

Reviewers

atul
kamil

Commits

rCOMMe0ef2fb5c16b: [landing] add size prop to logo components

Summary

In the figma designs we have different sizes for the competitor logos. For example in feature cards the logos are 30x30px but in the comparison selector component the logos are 50x50px. To make the size of the logos dynamic I added an optional size prop to each component. If the size field is not passed then we will default the size of the logo to 50x50 (the original size from Figma)

Depends on D7943

Test Plan

Please see the screenshots to see that I was able to change the sizes of the logos

Screenshot 2023-05-23 at 4.16.34 PM.png (2×3 px, 700 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.May 23 2023, 7:06 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 23 2023, 7:06 AM

ginsu edited the summary of this revision. (Show Details)May 23 2023, 7:09 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil.

ginsu added a parent revision: D7943: [landing] introduce logo svg assets for competitor comparison.

ginsu attached a referenced file: F554574: Screenshot 2023-05-23 at 4.16.34 PM.png. (Show Details)

Harbormaster completed remote builds in B19679: Diff 26887.May 23 2023, 7:24 AM

ginsu requested review of this revision.May 23 2023, 7:24 AM

ginsu added a child revision: D7904: [landing] introduce signal competitor data.May 24 2023, 5:58 AM

Can we change || to ?? before landing

landing/assets/comm-logo.react.js
9–15 ↗	(On Diff #26887)	Because `0` is falsey, if someone passed in size={0}, this would actually display the equivalent of size={50}. Could we instead do `size ?? 50`? In practice I really doubt it matters since I don't imagine anyone passing in size={0}, but just for correctness I guess.