Page MenuHomePhabricator
Differential D8028

[landing] key competitor data
ClosedPublic
Actions

Authored by ginsu on May 30 2023, 8:00 AM.
Tags
None
Referenced Files
F3366970: D8028.id27265.diff
Mon, Nov 25, 1:11 PM
Unknown Object (File)
Sun, Nov 17, 2:19 AM
Unknown Object (File)
Sun, Nov 17, 1:36 AM
Unknown Object (File)
Sun, Nov 17, 1:36 AM
Unknown Object (File)
Sun, Nov 17, 1:36 AM
Unknown Object (File)
Sun, Nov 17, 1:36 AM
Unknown Object (File)
Sat, Nov 16, 11:27 PM
Unknown Object (File)
Mon, Oct 28, 2:32 AM
View All 80 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM5de35fc7b603: [landing] key competitor data
Summary

In a subsequent diff we are going to want to access the competitor data by its key. This diff keys the competitorData so that we can do that

Depends on D8025

Test Plan

flow and this will be further tested in subsquent diffs

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.May 30 2023, 8:00 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 30 2023, 8:00 AM
ginsu edited the summary of this revision. (Show Details)May 30 2023, 8:08 AM
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8025: [landing] introduce feature modal component.
Harbormaster completed remote builds in B19903: Diff 27265.May 30 2023, 8:18 AM
ginsu requested review of this revision.May 30 2023, 8:18 AM
ginsu added a child revision: D8029: [landing] introduce Discord competitor data.May 30 2023, 8:56 AM
atul accepted this revision.May 30 2023, 8:58 AM

If we only plan on exporting keyedCompetitorData, could we just add keys to competitorData and turn it from array -> keyed obj?

This revision is now accepted and ready to land.May 30 2023, 8:58 AM
ginsu updated this revision to Diff 27271.May 30 2023, 11:00 AM

address comments

Harbormaster completed remote builds in B19909: Diff 27271.May 30 2023, 11:19 AM
atul added a comment.May 30 2023, 11:30 AM

(Looks like you added the Signal key in the update, did you mean to update the other entries as well?)

ginsu added a comment.May 30 2023, 11:32 AM

(Looks like you added the Signal key in the update, did you mean to update the other entries as well?)

Yes I will do that in each separate diff

ginsu updated this revision to Diff 29660.Aug 8 2023, 12:18 PM

rebase before landing

Harbormaster completed remote builds in B21620: Diff 29660.Aug 8 2023, 1:11 PM
Closed by commit rCOMM5de35fc7b603: [landing] key competitor data (authored by ginsu). · Explain WhyAug 8 2023, 2:08 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM5de35fc7b603: [landing] key competitor data.

Revision Contents
Changeset List

PathSize
landing/
6 lines

Diff 27271

View Options

landing/competitor-data.js

Loading...