Page MenuHomePhabricator

[landing] introduce Discord competitor data
ClosedPublic

Authored by ginsu on May 30 2023, 8:53 AM.
Tags
None
Referenced Files
F3366971: D8029.id27266.diff
Mon, Nov 25, 1:12 PM
Unknown Object (File)
Tue, Nov 19, 10:54 PM
Unknown Object (File)
Mon, Nov 18, 2:10 PM
Unknown Object (File)
Sun, Nov 17, 2:19 AM
Unknown Object (File)
Sun, Nov 17, 1:37 AM
Unknown Object (File)
Sun, Nov 17, 1:37 AM
Unknown Object (File)
Sun, Nov 17, 1:37 AM
Unknown Object (File)
Sun, Nov 17, 1:37 AM
Subscribers

Details

Summary

introduce discord competitor data. The copy was copied and pasted from this linear task.

Depends on D8028

Test Plan

Please see screenshots below:

Screenshot 2023-08-03 at 12.34.20 PM.png (2×3 px, 969 KB)

Screenshot 2023-08-03 at 12.34.41 PM.png (2×3 px, 931 KB)

Screenshot 2023-08-03 at 12.34.32 PM.png (2×3 px, 910 KB)

Screenshot 2023-08-03 at 12.34.07 PM.png (2×3 px, 833 KB)

Screenshot 2023-08-03 at 12.34.02 PM.png (2×3 px, 883 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the summary of this revision. (Show Details)
ginsu requested review of this revision.May 30 2023, 9:11 AM

change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu retitled this revision from DRAFT [landing] introduce Discord competitor data to [landing] introduce Discord competitor data.

Didn't read through copy, but diff looks good.

This revision is now accepted and ready to land.Aug 3 2023, 9:27 PM
This revision was automatically updated to reflect the committed changes.