Details

Reviewers

atul
kamil

Commits

rCOMMc573001f6540: [landing] introduce Matrix competitor data

Summary

introduce matrix competitor data. The copy was copied and pasted from this linear task.

Spoke to @ashoat IRL and we came to the conclusion that is was fine for the copy of the encryption card to have more than 3 lines

Depends on D8031

Test Plan

Please see the screenshots below:

Cards:

Screenshot 2023-07-18 at 1.30.13 PM.png (2×3 px, 954 KB)

Screenshot 2023-07-18 at 1.30.15 PM.png (2×3 px, 835 KB)

Modal:
Single paragraph example

Screenshot 2023-07-18 at 4.36.35 PM.png (2×3 px, 1020 KB)

multi paragraph example

Screenshot 2023-07-18 at 4.36.32 PM.png (2×3 px, 1011 KB)

scroll example

Screenshot 2023-07-18 at 4.22.15 PM.png (2×3 px, 1 MB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.May 30 2023, 8:57 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 30 2023, 8:57 AM

ginsu edited the summary of this revision. (Show Details)May 30 2023, 8:58 AM

ginsu added a parent revision: D8029: [landing] introduce Discord competitor data.

ginsu edited the summary of this revision. (Show Details)May 30 2023, 9:05 AM

ginsu added a parent revision: D8031: [landing] introduce keybase competitor data.

ginsu removed a parent revision: D8029: [landing] introduce Discord competitor data.

ginsu added a child revision: D8032: [landing] introduce slack competitor data.May 30 2023, 9:08 AM

Harbormaster completed remote builds in B19905: Diff 27267.May 30 2023, 9:15 AM

ginsu requested review of this revision.May 30 2023, 9:15 AM

add key

Harbormaster completed remote builds in B19912: Diff 27274.May 30 2023, 11:53 AM

update copy + change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.

Harbormaster completed remote builds in B21004: Diff 28794.Jul 18 2023, 2:30 PM

ginsu edited the summary of this revision. (Show Details)Jul 31 2023, 1:57 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil.

ginsu attached a referenced file: F669173: Screenshot 2023-07-18 at 1.30.13 PM.png. (Show Details)

ginsu attached a referenced file: F669174: Screenshot 2023-07-18 at 1.30.15 PM.png. (Show Details)

ginsu attached a referenced file: F669177: Screenshot 2023-07-18 at 4.36.32 PM.png. (Show Details)

ginsu attached a referenced file: F669176: Screenshot 2023-07-18 at 4.22.15 PM.png. (Show Details)

ginsu attached a referenced file: F669175: Screenshot 2023-07-18 at 4.36.35 PM.png. (Show Details)

ginsu edited the test plan for this revision. (Show Details)

ginsu retitled this revision from DRAFT [landing] introduce Matrix competitor data to [landing] introduce Matrix competitor data.

kamil accepted this revision.Aug 1 2023, 4:07 AM

kamil added inline comments.

landing/competitor-data.js
201 ↗	(On Diff #28794)	I am wondering, if using `security / privacy guarantees` vs `security/privacy guarantees`, or `client / server` vs `client/server` below is intentional here. (cc. @ashoat). In Polish, we use spaces before and after slash if items separated involve multiple words - and I also think that sometimes applies to English. Curious because eg. in line 253 there is a `Security Phrase/Key.` without any space. And if additional spaces are intentional, shouldn't this be ` `?

This revision is now accepted and ready to land.Aug 1 2023, 4:07 AM

ashoat added inline comments.Aug 1 2023, 6:50 AM

landing/competitor-data.js
201 ↗	(On Diff #28794)	That's fair – we can remove the spaces for consistency
201 ↗	(On Diff #28794)	Ginsu can you replace the " characters with “ and “? Please do this for the entire file