Details

Reviewers

atul
kamil

Commits

rCOMMbcc40390ddd5: [landing] introduce telegram competitor data

Summary

introduce telegram competitor data. The copy was copied and pasted from this linear task.

Depends on D8032

Test Plan

Please see screenshots below:

Screenshot 2023-08-06 at 3.50.45 PM.png (2×3 px, 893 KB)

Screenshot 2023-08-06 at 3.50.47 PM.png (2×3 px, 843 KB)

Screenshot 2023-08-06 at 3.51.00 PM.png (2×3 px, 973 KB)

Screenshot 2023-08-06 at 3.50.56 PM.png (2×3 px, 1011 KB)

Screenshot 2023-08-06 at 3.51.05 PM.png (2×3 px, 1013 KB)

Screenshot 2023-08-06 at 3.50.49 PM.png (2×3 px, 1017 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.May 30 2023, 9:10 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 30 2023, 9:10 AM

ginsu edited the summary of this revision. (Show Details)May 30 2023, 9:11 AM

ginsu added a parent revision: D8032: [landing] introduce slack competitor data.

Harbormaster returned this revision to the author for changes because remote builds failed.May 30 2023, 9:40 AM

Harbormaster failed remote builds in B19908: Diff 27270!

add key

Harbormaster completed remote builds in B19914: Diff 27276.May 30 2023, 11:55 AM

ginsu requested review of this revision.May 30 2023, 11:55 AM

ginsu added a child revision: D8034: [landing] introduce competitor comparison.May 31 2023, 8:49 AM

change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.

Harbormaster completed remote builds in B21006: Diff 28796.Jul 18 2023, 2:45 PM

update copy

ginsu retitled this revision from DRAFT [landing] introduce telegram competitor data to [landing] introduce telegram competitor data.Aug 6 2023, 1:57 PM

ginsu edited the summary of this revision. (Show Details)

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil.

ginsu edited the test plan for this revision. (Show Details)

ginsu attached a referenced file: F677189: Screenshot 2023-08-06 at 3.50.49 PM.png. (Show Details)

ginsu attached a referenced file: F677190: Screenshot 2023-08-06 at 3.50.47 PM.png. (Show Details)

ginsu attached a referenced file: F677191: Screenshot 2023-08-06 at 3.51.05 PM.png. (Show Details)

ginsu attached a referenced file: F677192: Screenshot 2023-08-06 at 3.50.56 PM.png. (Show Details)

ginsu attached a referenced file: F677188: Screenshot 2023-08-06 at 3.51.00 PM.png. (Show Details)

ginsu attached a referenced file: F677187: Screenshot 2023-08-06 at 3.50.45 PM.png. (Show Details)

Harbormaster completed remote builds in B21556: Diff 29572.Aug 6 2023, 2:10 PM

atul accepted this revision.Aug 7 2023, 10:30 PM