Page MenuHomePhabricator
Differential D8280

[web] Display `errorMessage` in `saveAvatarButton` on failure
ClosedPublic
Actions

Authored by atul on Jun 21 2023, 2:09 PM.
Tags
None
Referenced Files
F2109111: D8280.id.diff
Tue, Jun 25, 3:18 PM
Unknown Object (File)
Mon, Jun 24, 7:58 AM
Unknown Object (File)
Sun, Jun 23, 4:22 AM
Unknown Object (File)
Fri, Jun 21, 11:39 PM
Unknown Object (File)
May 26 2024, 12:43 PM
Unknown Object (File)
May 19 2024, 12:10 AM
Unknown Object (File)
May 19 2024, 12:10 AM
Unknown Object (File)
May 19 2024, 12:10 AM
View All 34 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
rohan
Commits
rCOMMd102a9e3ee01: [web] Display `errorMessage` in `saveAvatarButton` on failure
Summary

Style button and show error message if save emoji avatar request fails.

Depends on D8279

Test Plan

Looks as expected:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jun 21 2023, 2:09 PM
Herald added a subscriber: tomek. · View Herald TranscriptJun 21 2023, 2:09 PM
atul added inline comments.Jun 21 2023, 2:11 PM
web/avatars/web-edit-user-avatar-provider.react.js
7 ↗(On Diff #27978)

Going to leave this unimplemented. In future diff I'll make displayAvatarUpdateFailureAlert prop optional. It makes sense to show an Alert on native where that's the pattern, but doesn't make sense on web.

Harbormaster completed remote builds in B20406: Diff 27978.Jun 21 2023, 2:29 PM
atul requested review of this revision.Jun 21 2023, 2:29 PM
atul added a child revision: D8281: [web] Indicate success via `saveAvatarButton` on success.Jun 21 2023, 2:42 PM
atul mentioned this in D8283: [web] Consolidate `errorMessage` and `updateSuccessful` state in `EmojiAvatarSelectionModal`.Jun 21 2023, 2:58 PM
rohan accepted this revision.Jun 22 2023, 6:20 AM

I don't think your screenshot attached in the test plan but the code seems good

This revision is now accepted and ready to land.Jun 22 2023, 6:20 AM
atul updated this revision to Diff 28078.Jun 23 2023, 1:55 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jun 23 2023, 2:07 PM
Closed by commit rCOMMd102a9e3ee01: [web] Display `errorMessage` in `saveAvatarButton` on failure (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMd102a9e3ee01: [web] Display `errorMessage` in `saveAvatarButton` on failure.
atul mentioned this in rCOMM72b8c7fcb7f5: [web] Consolidate `errorMessage` and `updateSuccessful` state in….
Harbormaster completed remote builds in B20492: Diff 28078.Jun 23 2023, 2:20 PM

Revision Contents
Changeset List

Diff 28091

View Options

web/avatars/emoji-avatar-selection-modal.css

Loading...
View Options

web/avatars/emoji-avatar-selection-modal.react.js

Loading...
View Options

web/avatars/web-edit-user-avatar-provider.react.js

Loading...