Page MenuHomePhabricator

[web] Move `editAvatarBadge` div to `EditUserAvatarMenu`
ClosedPublic

Authored by atul on Jun 20 2023, 11:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 4:36 PM
Unknown Object (File)
Mon, Mar 10, 1:09 PM
Unknown Object (File)
Sat, Mar 8, 12:42 PM
Unknown Object (File)
Sat, Mar 8, 12:42 PM
Unknown Object (File)
Sat, Mar 8, 12:42 PM
Unknown Object (File)
Sat, Mar 8, 12:40 PM
Unknown Object (File)
Fri, Mar 7, 6:03 AM
Unknown Object (File)
Feb 17 2025, 3:51 PM
Subscribers

Details

Summary

Currently only the pencil icon is "clickable," we want the whole thing to be "clickable."

Known regression:

23d369.png (744×726 px, 77 KB)

The menu is appearing right below the icon rather than below the "badge." Will address this layout issue in subsequent diff.


Depends on D8261

Test Plan

"Whole button" is clickable.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul requested review of this revision.Jun 20 2023, 12:12 PM

The menu is appearing right below the icon rather than below the "badge." Will address this layout issue in subsequent diff.

Can you link it?

This revision is now accepted and ready to land.Jun 22 2023, 4:54 AM
In D8263#244474, @kamil wrote:

The menu is appearing right below the icon rather than below the "badge." Will address this layout issue in subsequent diff.

Can you link it?

Haven't put it up yet, it requires modifying Menu component so deferring for the end of the stack