Page MenuHomePhabricator
Differential D8263

[web] Move `editAvatarBadge` div to `EditUserAvatarMenu`
ClosedPublic
Actions

Authored by atul on Jun 20 2023, 11:55 AM.
Tags
None
Referenced Files
F2101470: D8263.id.diff
Mon, Jun 24, 10:30 PM
Unknown Object (File)
Sat, Jun 22, 5:03 AM
Unknown Object (File)
Thu, Jun 13, 5:40 AM
Unknown Object (File)
Mon, Jun 3, 10:55 PM
Unknown Object (File)
Sun, Jun 2, 9:03 PM
Unknown Object (File)
Sun, Jun 2, 9:03 PM
Unknown Object (File)
May 5 2024, 7:01 AM
Unknown Object (File)
May 4 2024, 2:45 PM
View All 51 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
rohan
inka
michal
kamil
Commits
rCOMM349d0eec12f8: [web] Move `editAvatarBadge` div to `EditUserAvatarMenu`
Summary

Currently only the pencil icon is "clickable," we want the whole thing to be "clickable."

Known regression:

23d369.png (744×726 px, 77 KB)

The menu is appearing right below the icon rather than below the "badge." Will address this layout issue in subsequent diff.

Depends on D8261

Test Plan

"Whole button" is clickable.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jun 20 2023, 11:55 AM
Herald added a subscriber: tomek. · View Herald TranscriptJun 20 2023, 11:55 AM
atul edited the summary of this revision. (Show Details)Jun 20 2023, 11:55 AM
atul added a child revision: D8264: [web] Hide `EditUserAvatarMenu` when `userAvatarSaveInProgress`.Jun 20 2023, 12:02 PM
Harbormaster completed remote builds in B20364: Diff 27909.Jun 20 2023, 12:12 PM
atul requested review of this revision.Jun 20 2023, 12:12 PM
atul added reviewers: rohan, inka, michal, kamil.Jun 21 2023, 9:45 AM
kamil accepted this revision.Jun 22 2023, 4:54 AM

The menu is appearing right below the icon rather than below the "badge." Will address this layout issue in subsequent diff.

Can you link it?

This revision is now accepted and ready to land.Jun 22 2023, 4:54 AM
atul added a comment.Jun 22 2023, 10:50 AM
In D8263#244474, @kamil wrote:

The menu is appearing right below the icon rather than below the "badge." Will address this layout issue in subsequent diff.

Can you link it?

Haven't put it up yet, it requires modifying Menu component so deferring for the end of the stack

Closed by commit rCOMM349d0eec12f8: [web] Move `editAvatarBadge` div to `EditUserAvatarMenu` (authored by atul). · Explain WhyJun 22 2023, 10:56 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM349d0eec12f8: [web] Move `editAvatarBadge` div to `EditUserAvatarMenu`.

Revision Contents
Changeset List

PathSize
web/
avatars/
edit-user-avatar-menu.css
edit-user-avatar.css
13 lines
7 lines
21 lines
4 lines

Diff 28011

View Options

web/avatars/edit-user-avatar-menu.css

Loading...
View Options

web/avatars/edit-user-avatar-menu.react.js

Loading...
View Options

web/avatars/edit-user-avatar.css

Loading...
View Options

web/avatars/edit-user-avatar.react.js

Loading...