Page MenuHomePhabricator

[web] Display `loadingSpinner` over `EditUserAvatar` when change in progress
ClosedPublic

Authored by atul on Jun 20 2023, 10:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 22, 3:35 PM
Unknown Object (File)
Sat, Mar 15, 4:36 PM
Unknown Object (File)
Sat, Mar 8, 12:42 PM
Unknown Object (File)
Sat, Mar 8, 12:42 PM
Unknown Object (File)
Sat, Mar 8, 12:42 PM
Unknown Object (File)
Sat, Mar 8, 12:42 PM
Unknown Object (File)
Sat, Mar 8, 12:42 PM
Unknown Object (File)
Sat, Mar 8, 12:39 PM
Subscribers

Details

Summary

Show a loading spinner over EditUserAvatar when a save is in progress. Pretty straightforward. In next diff I'll quickly "disable" the edit button as well.


Depends on D8260

Test Plan

Looks as expected:

21c58a.png (1×996 px, 92 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Jun 20 2023, 10:49 AM
atul edited the test plan for this revision. (Show Details)
atul added inline comments.
web/avatars/edit-user-avatar.react.js
25–28 ↗(On Diff #27905)

Ah, let me pull this out.

pull out loadingSpinner from component

This revision is now accepted and ready to land.Jun 22 2023, 4:41 AM
This revision was landed with ongoing or failed builds.Jun 22 2023, 10:56 AM
This revision was automatically updated to reflect the committed changes.