Page MenuHomePhabricator
Differential D8261

[web] Display `loadingSpinner` over `EditUserAvatar` when change in progress
ClosedPublic
Actions

Authored by atul on Jun 20 2023, 10:49 AM.
Tags
None
Referenced Files
F2108635: D8261.id28007.diff
Tue, Jun 25, 1:42 PM
F2105276: D8261.id28009.diff
Tue, Jun 25, 6:46 AM
Unknown Object (File)
Fri, Jun 21, 11:57 PM
Unknown Object (File)
Sat, Jun 15, 2:13 PM
Unknown Object (File)
Thu, Jun 13, 3:13 PM
Unknown Object (File)
Thu, Jun 13, 11:53 AM
Unknown Object (File)
May 19 2024, 12:08 AM
Unknown Object (File)
Apr 24 2024, 8:44 AM
View All 38 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
rohan
inka
kamil
michal
Commits
rCOMMb6e7da51ff11: [web] Display `loadingSpinner` over `EditUserAvatar` when change in progress
Summary

Show a loading spinner over EditUserAvatar when a save is in progress. Pretty straightforward. In next diff I'll quickly "disable" the edit button as well.

Depends on D8260

Test Plan

Looks as expected:

21c58a.png (1×996 px, 92 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jun 20 2023, 10:49 AM
Herald added a subscriber: tomek. · View Herald TranscriptJun 20 2023, 10:49 AM
atul published this revision for review.Jun 20 2023, 10:49 AM
atul edited the test plan for this revision. (Show Details)
atul added inline comments.
web/avatars/edit-user-avatar.react.js
25–28 ↗(On Diff #27905)

Ah, let me pull this out.

atul updated this revision to Diff 27906.Jun 20 2023, 10:57 AM

pull out loadingSpinner from component

Harbormaster completed remote builds in B20360: Diff 27905.Jun 20 2023, 11:06 AM
Harbormaster completed remote builds in B20361: Diff 27906.Jun 20 2023, 11:14 AM
atul added a child revision: D8263: [web] Move `editAvatarBadge` div to `EditUserAvatarMenu`.Jun 20 2023, 11:55 AM
atul added reviewers: rohan, inka, kamil, michal.Jun 21 2023, 9:45 AM
kamil accepted this revision.Jun 22 2023, 4:41 AM
This revision is now accepted and ready to land.Jun 22 2023, 4:41 AM
atul updated this revision to Diff 28007.Jun 22 2023, 10:53 AM

undefined -> null

This revision was landed with ongoing or failed builds.Jun 22 2023, 10:56 AM
Closed by commit rCOMMb6e7da51ff11: [web] Display `loadingSpinner` over `EditUserAvatar` when change in progress (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMb6e7da51ff11: [web] Display `loadingSpinner` over `EditUserAvatar` when change in progress.
Harbormaster failed remote builds in B20433: Diff 28007!Jun 22 2023, 11:15 AM

Revision Contents
Changeset List

PathSize
web/
avatars/
7 lines
14 lines

Diff 28009

View Options

web/avatars/edit-user-avatar.css

Loading...
View Options

web/avatars/edit-user-avatar.react.js

Loading...