Page MenuHomePhabricator
Differential D8260

[web] Add `removeUserAvatar` to `EditUserAvatarMenu`
ClosedPublic
Actions

Authored by atul on Jun 20 2023, 10:24 AM.
Tags
None
Referenced Files
F2109997: D8260.id.diff
Tue, Jun 25, 6:18 PM
F2103569: D8260.diff
Tue, Jun 25, 3:32 AM
Unknown Object (File)
Mon, Jun 3, 10:55 PM
Unknown Object (File)
Sun, Jun 2, 9:02 PM
Unknown Object (File)
Sun, Jun 2, 9:01 PM
Unknown Object (File)
Sun, Jun 2, 9:01 PM
Unknown Object (File)
Sun, Jun 2, 9:01 PM
Unknown Object (File)
Sun, Jun 2, 9:01 PM
View All 77 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
rohan
kamil
inka
michal
Commits
rCOMM964adba37cf9: [web] Add `removeUserAvatar` to `EditUserAvatarMenu`
Summary

Sets "Reset to default" menu item onClick to removeUserAvatar which removes the user's avatar.

Test Plan

Works as expected. User had image avatar, now they have default emoji avatar:

46dbcb.png (994×996 px, 91 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jun 20 2023, 10:24 AM
Herald added a subscriber: tomek. · View Herald TranscriptJun 20 2023, 10:24 AM
atul edited the test plan for this revision. (Show Details)Jun 20 2023, 10:25 AM
Harbormaster completed remote builds in B20358: Diff 27903.Jun 20 2023, 10:42 AM
atul requested review of this revision.Jun 20 2023, 10:42 AM
atul added a child revision: D8261: [web] Display `loadingSpinner` over `EditUserAvatar` when change in progress.Jun 20 2023, 10:49 AM
atul added reviewers: rohan, kamil, inka, michal.Jun 21 2023, 9:45 AM
rohan accepted this revision.Jun 21 2023, 10:27 AM
rohan added inline comments.
web/avatars/edit-user-avatar-menu.react.js
20–23 ↗(On Diff #27903)

You could probably use shorthand here

This revision is now accepted and ready to land.Jun 21 2023, 10:27 AM
atul added inline comments.Jun 21 2023, 11:21 AM
web/avatars/edit-user-avatar-menu.react.js
20–23 ↗(On Diff #27903)

Thanks for catching that, will update.

atul updated this revision to Diff 27973.Jun 21 2023, 11:23 AM

rebase before addressing feedback

atul updated this revision to Diff 27974.Jun 21 2023, 11:24 AM

rebase before landing

This revision was landed with ongoing or failed builds.Jun 21 2023, 11:30 AM
Closed by commit rCOMM964adba37cf9: [web] Add `removeUserAvatar` to `EditUserAvatarMenu` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM964adba37cf9: [web] Add `removeUserAvatar` to `EditUserAvatarMenu`.
Harbormaster completed remote builds in B20402: Diff 27973.Jun 21 2023, 11:41 AM
Harbormaster completed remote builds in B20403: Diff 27974.

Revision Contents
Changeset List

PathSize
web/
avatars/
23 lines

Diff 27975

View Options

web/avatars/edit-user-avatar-menu.react.js

Loading...