Paths

Table of Contentst

[web] Style "Emoji" tab of `EmojiAvatarSelectionModal`
ClosedPublic
Actions

Authored by atul on Jun 21 2023, 4:26 PM.

Details

Reviewers

ashoat
ginsu
rohan

Commits

rCOMM12e2671bb066: [web] Style "Emoji" tab of `EmojiAvatarSelectionModal`

Summary

Here's how it looks:

Here it is w/ some "debugging" guides:

Depends on D8287

Test Plan

NA, see above

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jun 21 2023, 4:26 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 21 2023, 4:26 PM

atul published this revision for review.Jun 21 2023, 4:27 PM

atul edited the summary of this revision. (Show Details)

atul added inline comments.

web/avatars/emoji-avatar-selection-modal.css
5 ↗	(On Diff #27988)	Don't love hardcoding dimensions, but not sure how else to keep the tabs the same height

update min-height to account for tabBody padding

Harbormaster completed remote builds in B20416: Diff 27988.Jun 21 2023, 4:43 PM

Harbormaster completed remote builds in B20417: Diff 27989.Jun 21 2023, 4:47 PM

ginsu accepted this revision.Jun 22 2023, 4:08 PM

This revision is now accepted and ready to land.Jun 22 2023, 4:08 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jun 23 2023, 2:07 PM

Closed by commit rCOMM12e2671bb066: [web] Style "Emoji" tab of `EmojiAvatarSelectionModal` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM12e2671bb066: [web] Style "Emoji" tab of `EmojiAvatarSelectionModal`.

Harbormaster completed remote builds in B20498: Diff 28084.Jun 23 2023, 2:57 PM

Revision Contents
Changeset List

Path

Size

web/

avatars/

emoji-avatar-selection-modal.css

13 lines

emoji-avatar-selection-modal.react.js

11 lines

Diff 28098

View Options

web/avatars/emoji-avatar-selection-modal.css