Page MenuHomePhabricator
Differential D8278

[web] Add "Save Avatar" button to `EmojiAvatarSelectionModal`
ClosedPublic
Actions

Authored by atul on Jun 21 2023, 12:27 PM.
Tags
None
Referenced Files
F5926924: D8278.id28076.diff
Fri, Apr 18, 12:34 AM
F5910875: D8278.id28089.diff
Thu, Apr 17, 4:50 PM
F5907800: D8278.diff
Thu, Apr 17, 2:40 PM
Unknown Object (File)
Wed, Apr 16, 5:23 PM
Unknown Object (File)
Fri, Apr 11, 3:39 AM
Unknown Object (File)
Mon, Mar 31, 5:22 PM
Unknown Object (File)
Mar 15 2025, 4:36 PM
Unknown Object (File)
Mar 5 2025, 4:02 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
inka
rohan
kamil
michal
Commits
rCOMMba9ba6041bfe: [web] Add "Save Avatar" button to `EmojiAvatarSelectionModal`
Summary

For now just sets user avatar to pendingEmojiAvatar.

In subsequent diffs we will handle success/failure states properly.

Depends on D8269

Test Plan

Works as expected:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jun 21 2023, 12:27 PM
Herald added a subscriber: tomek. · View Herald TranscriptJun 21 2023, 12:27 PM
atul edited the test plan for this revision. (Show Details)Jun 21 2023, 12:29 PM
Harbormaster completed remote builds in B20404: Diff 27976.Jun 21 2023, 12:45 PM
atul requested review of this revision.Jun 21 2023, 12:45 PM
atul added a child revision: D8279: [web] Style and disable "Save Avatar" button when `userAvatarSaveInProgress`.Jun 21 2023, 12:52 PM
atul added reviewers: inka, rohan, kamil, michal.Jun 21 2023, 12:53 PM
rohan accepted this revision.Jun 22 2023, 7:25 AM
This revision is now accepted and ready to land.Jun 22 2023, 7:25 AM
atul updated this revision to Diff 28076.Jun 23 2023, 1:53 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jun 23 2023, 2:07 PM
Closed by commit rCOMMba9ba6041bfe: [web] Add "Save Avatar" button to `EmojiAvatarSelectionModal` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMba9ba6041bfe: [web] Add "Save Avatar" button to `EmojiAvatarSelectionModal`.
Harbormaster completed remote builds in B20490: Diff 28076.Jun 23 2023, 2:10 PM

Revision Contents
Changeset List

Diff 28089

View Options

web/avatars/emoji-avatar-selection-modal.css

Show First 20 Lines • Show All 658 Lines • ▼ Show 20 Lines async () => {
AND (t.type = ${threadTypes.COMMUNITY_ROOT} AND (t.type = ${threadTypes.COMMUNITY_ROOT}
OR t.type = ${threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT}) OR t.type = ${threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT})
`); `);
await dbQuery(updateQuery); await dbQuery(updateQuery);
}, },
], ],
[52, updateRolesAndPermissionsForAllThreads], [52, updateRolesAndPermissionsForAllThreads],
[
53,
async () =>
dbQuery(SQL`
ALTER TABLE invite_links
ADD COLUMN blob_holder char(36) CHARSET latin1
`),
],
]); ]);
const newDatabaseVersion: number = Math.max(...migrations.keys()); const newDatabaseVersion: number = Math.max(...migrations.keys());
async function writeJSONToFile(data: any, filePath: string): Promise<void> { async function writeJSONToFile(data: any, filePath: string): Promise<void> {
console.warn(`updating ${filePath} to ${JSON.stringify(data)}`); console.warn(`updating ${filePath} to ${JSON.stringify(data)}`);
const fileHandle = await fs.promises.open(filePath, 'w'); const fileHandle = await fs.promises.open(filePath, 'w');
await fileHandle.writeFile(JSON.stringify(data, null, ' '), 'utf8'); await fileHandle.writeFile(JSON.stringify(data, null, ' '), 'utf8');
await fileHandle.close(); await fileHandle.close();
▲ Show 20 Lines • Show All 118 Lines • Show Last 20 Lines
View Options

web/avatars/emoji-avatar-selection-modal.react.js

Show First 20 Lines • Show All 658 Lines • ▼ Show 20 Lines async () => {
AND (t.type = ${threadTypes.COMMUNITY_ROOT} AND (t.type = ${threadTypes.COMMUNITY_ROOT}
OR t.type = ${threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT}) OR t.type = ${threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT})
`); `);
await dbQuery(updateQuery); await dbQuery(updateQuery);
}, },
], ],
[52, updateRolesAndPermissionsForAllThreads], [52, updateRolesAndPermissionsForAllThreads],
[
53,
async () =>
dbQuery(SQL`
ALTER TABLE invite_links
ADD COLUMN blob_holder char(36) CHARSET latin1
`),
],
]); ]);
const newDatabaseVersion: number = Math.max(...migrations.keys()); const newDatabaseVersion: number = Math.max(...migrations.keys());
async function writeJSONToFile(data: any, filePath: string): Promise<void> { async function writeJSONToFile(data: any, filePath: string): Promise<void> {
console.warn(`updating ${filePath} to ${JSON.stringify(data)}`); console.warn(`updating ${filePath} to ${JSON.stringify(data)}`);
const fileHandle = await fs.promises.open(filePath, 'w'); const fileHandle = await fs.promises.open(filePath, 'w');
await fileHandle.writeFile(JSON.stringify(data, null, ' '), 'utf8'); await fileHandle.writeFile(JSON.stringify(data, null, ' '), 'utf8');
await fileHandle.close(); await fileHandle.close();
▲ Show 20 Lines • Show All 118 Lines • Show Last 20 Lines