Page MenuHomePhabricator
Differential D8278

[web] Add "Save Avatar" button to `EmojiAvatarSelectionModal`
ClosedPublic
Actions

Authored by atul on Jun 21 2023, 12:27 PM.
Tags
None
Referenced Files
F3407559: D8278.diff
Wed, Dec 4, 6:40 AM
Unknown Object (File)
Mon, Dec 2, 11:53 AM
Unknown Object (File)
Sat, Nov 23, 1:10 PM
Unknown Object (File)
Sat, Nov 23, 1:10 PM
Unknown Object (File)
Sat, Nov 23, 1:10 PM
Unknown Object (File)
Sat, Nov 9, 8:36 PM
Unknown Object (File)
Sat, Nov 9, 8:36 PM
Unknown Object (File)
Sat, Nov 9, 6:31 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
inka
rohan
kamil
michal
Commits
rCOMMba9ba6041bfe: [web] Add "Save Avatar" button to `EmojiAvatarSelectionModal`
Summary

For now just sets user avatar to pendingEmojiAvatar.

In subsequent diffs we will handle success/failure states properly.

Depends on D8269

Test Plan

Works as expected:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jun 21 2023, 12:27 PM
Herald added a subscriber: tomek. · View Herald TranscriptJun 21 2023, 12:27 PM
atul edited the test plan for this revision. (Show Details)Jun 21 2023, 12:29 PM
Harbormaster completed remote builds in B20404: Diff 27976.Jun 21 2023, 12:45 PM
atul requested review of this revision.Jun 21 2023, 12:45 PM
atul added a child revision: D8279: [web] Style and disable "Save Avatar" button when `userAvatarSaveInProgress`.Jun 21 2023, 12:52 PM
atul added reviewers: inka, rohan, kamil, michal.Jun 21 2023, 12:53 PM
rohan accepted this revision.Jun 22 2023, 7:25 AM
This revision is now accepted and ready to land.Jun 22 2023, 7:25 AM
atul updated this revision to Diff 28076.Jun 23 2023, 1:53 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jun 23 2023, 2:07 PM
Closed by commit rCOMMba9ba6041bfe: [web] Add "Save Avatar" button to `EmojiAvatarSelectionModal` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMba9ba6041bfe: [web] Add "Save Avatar" button to `EmojiAvatarSelectionModal`.
Harbormaster completed remote builds in B20490: Diff 28076.Jun 23 2023, 2:10 PM

Revision Contents
Changeset List

Diff 28089

View Options

web/avatars/emoji-avatar-selection-modal.css

Loading...
View Options

web/avatars/emoji-avatar-selection-modal.react.js

Loading...