[Keyserver] Refactor prekey lifecycle logic
AbandonedPublic
Actions

Authored by • jon on Jul 11 2023, 10:00 AM.

Details

Reviewers

kamil
michal

Summary

This is useful in implementing the identity
integration, refactor this logic into their own methods.

Part of https://linear.app/comm/issue/ENG-3944

Depends on D8473

Test Plan

N/A, tested in later diff

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Jul 11 2023, 10:00 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 11 2023, 10:00 AM

• jon added a child revision: D8475: [Keyserver] Refactor identity utilities.Jul 11 2023, 10:03 AM

Harbormaster completed remote builds in B20869: Diff 28589.Jul 11 2023, 10:17 AM

• jon requested review of this revision.Jul 11 2023, 10:17 AM

kamil accepted this revision.Jul 17 2023, 2:48 AM

kamil added inline comments.

keyserver/src/utils/olm-utils.js
92–101	you can early exit here to make the return statement simpler (this also applies to `shouldRotatePrekey`)
103	based on the previous stack `async` here is not needed but it looks like you did not rebase this diff

This revision is now accepted and ready to land.Jul 17 2023, 2:48 AM

I rebased this into D8476. But I applied your suggestion @kamil, thanks

• jon removed a parent revision: D8473: [Keyserver/rust] Add publish_prekeys implementation.Jul 24 2023, 6:41 AM

• jon removed a child revision: D8475: [Keyserver] Refactor identity utilities.

• jon added a child revision: D8475: [Keyserver] Refactor identity utilities.Aug 17 2023, 8:19 AM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

utils/

olm-utils.js

31 lines

Diff 28589

View Options

keyserver/src/utils/olm-utils.js

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };

[Keyserver] Refactor prekey lifecycle logicAbandonedPublicActions