Page MenuHomePhabricator
Differential D8475

[Keyserver] Refactor identity utilities
ClosedPublic
Actions

Authored by • jon on Jul 11 2023, 10:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 2, 4:12 AM
Unknown Object (File)
Sat, Mar 29, 11:40 AM
Unknown Object (File)
Tue, Mar 11, 12:54 PM
Unknown Object (File)
Wed, Mar 5, 4:57 PM
Unknown Object (File)
Wed, Mar 5, 2:53 AM
Unknown Object (File)
Mar 1 2025, 7:55 PM
Unknown Object (File)
Mar 1 2025, 7:55 PM
Unknown Object (File)
Mar 1 2025, 7:55 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
michal
ashoat
Commits
rCOMM4b40142ee014: [Keyserver] Refactor identity utilities
Summary

These are useful when interacting with identity service,
pull them out of login.js to make them more widely available.

Part of https://linear.app/comm/issue/ENG-3944

Depends on D8474

Test Plan

Launch keyserver with login workflow (missing identity info)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Jul 11 2023, 10:03 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 11 2023, 10:03 AM
• jon added a child revision: D8476: [Keyserver] Publish prekeys to identity service for cron job.Jul 11 2023, 10:09 AM
Harbormaster completed remote builds in B20870: Diff 28590.Jul 11 2023, 10:29 AM
• jon requested review of this revision.Jul 11 2023, 10:29 AM
• jon added inline comments.Jul 14 2023, 3:33 PM
keyserver/src/user/identity.js
27 ↗(On Diff #28590)

Apply https://phab.comm.dev/D8405#inline-54532 to this refactor

• jon updated this revision to Diff 28697.Jul 14 2023, 3:37 PM

Remove extra async

Harbormaster completed remote builds in B20941: Diff 28697.Jul 14 2023, 3:54 PM
kamil accepted this revision.Jul 17 2023, 2:59 AM
kamil added inline comments.
keyserver/src/user/login.js
11–12 ↗(On Diff #28697)

nit: merge imports

This revision is now accepted and ready to land.Jul 17 2023, 2:59 AM
• jon updated this revision to Diff 28967.Jul 24 2023, 6:35 AM

Rebase on master

• jon added a parent revision: D8473: [Keyserver/rust] Add publish_prekeys implementation.Jul 24 2023, 6:41 AM
• jon removed a parent revision: D8474: [Keyserver] Refactor prekey lifecycle logic.
Harbormaster completed remote builds in B21145: Diff 28967.Jul 24 2023, 7:09 AM
• jon updated this revision to Diff 30014.Aug 17 2023, 8:19 AM
• jon added a parent revision: D8474: [Keyserver] Refactor prekey lifecycle logic.

Use userID when able to

• jon updated this revision to Diff 30015.Aug 17 2023, 8:21 AM
• jon marked an inline comment as done.

Combine imports

• jon added a comment.Aug 17 2023, 8:22 AM

Address Kamil's feedback

• jon added a reviewer: ashoat.Aug 17 2023, 8:22 AM
This revision now requires review to proceed.Aug 17 2023, 8:22 AM
Harbormaster completed remote builds in B21842: Diff 30014.Aug 17 2023, 8:38 AM
Harbormaster completed remote builds in B21843: Diff 30015.
ashoat accepted this revision.Aug 18 2023, 3:23 PM
This revision is now accepted and ready to land.Aug 18 2023, 3:23 PM
Closed by commit rCOMM4b40142ee014: [Keyserver] Refactor identity utilities (authored by • jon). · Explain WhyAug 20 2023, 11:47 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM4b40142ee014: [Keyserver] Refactor identity utilities.

Revision Contents
Changeset List

PathSize
keyserver/
src/
user/
38 lines
32 lines

Diff 30014

View Options

keyserver/src/user/identity.js

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
const styles = StyleSheet.create({ const styles = StyleSheet.create({
dummyMessage: { dummyMessage: {
paddingHorizontal: 12, paddingHorizontal: 12,
paddingVertical: 6, paddingVertical: 6,
}, },
message: { message: {
overflow: 'hidden', overflow: 'hidden',
paddingHorizontal: 12, paddingHorizontal: 12,
paddingVertical: 6, paddingVertical: 8,
}, },
text: { text: {
fontFamily: 'Arial', fontFamily: 'Arial',
fontSize: 18, fontSize: 14,
benschacAuthorUnsubmitted
Done
Inline Actions

I actually think this is a bit too small. But that's what's in the design.

https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455

@ashoat - I think 16px looks better.

image.png (1×2 px, 2 MB)

benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
lineHeight: 22,
}, },
}); });
export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement }; export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };
View Options

keyserver/src/user/login.js

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
const styles = StyleSheet.create({ const styles = StyleSheet.create({
dummyMessage: { dummyMessage: {
paddingHorizontal: 12, paddingHorizontal: 12,
paddingVertical: 6, paddingVertical: 6,
}, },
message: { message: {
overflow: 'hidden', overflow: 'hidden',
paddingHorizontal: 12, paddingHorizontal: 12,
paddingVertical: 6, paddingVertical: 8,
}, },
text: { text: {
fontFamily: 'Arial', fontFamily: 'Arial',
fontSize: 18, fontSize: 14,
benschacAuthorUnsubmitted
Done
Inline Actions

I actually think this is a bit too small. But that's what's in the design.

https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455

@ashoat - I think 16px looks better.

image.png (1×2 px, 2 MB)

benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
lineHeight: 22,
}, },
}); });
export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement }; export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };