Page MenuHomePhabricator
Differential D8554

[web] rework report tests to use CommQueryExecutor
ClosedPublic
Actions

Authored by kamil on Jul 19 2023, 6:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 6:10 PM
Unknown Object (File)
Wed, Mar 12, 10:21 PM
Unknown Object (File)
Tue, Mar 11, 5:13 PM
Unknown Object (File)
Tue, Mar 11, 3:50 PM
Unknown Object (File)
Mar 7 2025, 1:20 AM
Unknown Object (File)
Mar 5 2025, 2:20 AM
Unknown Object (File)
Mar 4 2025, 5:54 PM
Unknown Object (File)
Mar 4 2025, 5:54 PM
View All Files
Subscribers
ashoat

Details

Reviewers
michal
tomek
Commits
rCOMM31dc137a10f9: [web] rework report tests to use CommQueryExecutor
Summary

Updates test to new module

Depends on D8553

Test Plan

Run tests

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jul 19 2023, 6:53 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 19 2023, 6:53 AM
kamil added a child revision: D8555: [web] rework metadata tests to use CommQueryExecutor.Jul 19 2023, 6:55 AM
Harbormaster completed remote builds in B21033: Diff 28829.Jul 19 2023, 7:14 AM
kamil published this revision for review.Jul 19 2023, 9:02 AM
kamil added inline comments.
web/database/queries/report-queries.test.js
34 ↗(On Diff #28829)

this test is no longer relevant, table is created via native code

michal accepted this revision.Jul 21 2023, 5:59 AM

Nice!

This revision is now accepted and ready to land.Jul 21 2023, 5:59 AM
kamil updated this revision to Diff 29002.Jul 25 2023, 2:06 AM

rebase

kamil edited parent revisions, added: D8558: [web] rework database module tests to use CommQueryExecutor; removed: D8553: [web] add SQLiteQueryExecutor bindings and type.Jul 25 2023, 2:07 AM
Harbormaster completed remote builds in B21169: Diff 29002.Jul 25 2023, 2:41 AM
Closed by commit rCOMM31dc137a10f9: [web] rework report tests to use CommQueryExecutor (authored by kamil). · Explain WhyJul 27 2023, 5:40 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM31dc137a10f9: [web] rework report tests to use CommQueryExecutor.

Revision Contents
Changeset List

PathSize
web/
database/
queries/
61 lines

Diff 29002

View Options

web/database/queries/report-queries.test.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { import {
sortMessageInfoList, sortMessageInfoList,
shimUnsupportedRawMessageInfos, shimUnsupportedRawMessageInfos,
} from 'lib/shared/message-utils.js'; } from 'lib/shared/message-utils.js';
import { messageSpecs } from 'lib/shared/messages/message-specs.js'; import { messageSpecs } from 'lib/shared/messages/message-specs.js';
import { notifCollapseKeyForRawMessageInfo } from 'lib/shared/notif-utils.js'; import { getNotifCollapseKey } from 'lib/shared/notif-utils.js';
import { hasMinCodeVersion } from 'lib/shared/version-utils.js'; import { hasMinCodeVersion } from 'lib/shared/version-utils.js';
import { import {
type RawMessageInfo, type RawMessageInfo,
type RawComposableMessageInfo, type RawComposableMessageInfo,
type RawRobotextMessageInfo, type RawRobotextMessageInfo,
messageTypes, messageTypes,
type MessageType, type MessageType,
assertMessageType, assertMessageType,
▲ Show 20 Lines • Show All 42 Lines • ▼ Show 20 Linesasync function fetchCollapsableNotifs(
pushInfo: PushInfo, pushInfo: PushInfo,
): Promise<FetchCollapsableNotifsResult> { ): Promise<FetchCollapsableNotifsResult> {
// First, we need to fetch any notifications that should be collapsed // First, we need to fetch any notifications that should be collapsed
const usersToCollapseKeysToInfo = {}; const usersToCollapseKeysToInfo = {};
const usersToCollapsableNotifInfo = {}; const usersToCollapsableNotifInfo = {};
for (const userID in pushInfo) { for (const userID in pushInfo) {
usersToCollapseKeysToInfo[userID] = {}; usersToCollapseKeysToInfo[userID] = {};
usersToCollapsableNotifInfo[userID] = []; usersToCollapsableNotifInfo[userID] = [];
for (const rawMessageInfo of pushInfo[userID].messageInfos) { for (let i = 0; i < pushInfo[userID].messageInfos.length; i++) {
const collapseKey = notifCollapseKeyForRawMessageInfo(rawMessageInfo); const rawMessageInfo = pushInfo[userID].messageInfos[i];
const messageData = pushInfo[userID].messageDatas[i];
const collapseKey = getNotifCollapseKey(rawMessageInfo, messageData);
if (!collapseKey) { if (!collapseKey) {
const collapsableNotifInfo = { const collapsableNotifInfo = {
collapseKey, collapseKey,
existingMessageInfos: [], existingMessageInfos: [],
newMessageInfos: [rawMessageInfo], newMessageInfos: [rawMessageInfo],
}; };
usersToCollapsableNotifInfo[userID].push(collapsableNotifInfo); usersToCollapsableNotifInfo[userID].push(collapsableNotifInfo);
continue; continue;
▲ Show 20 Lines • Show All 652 Lines • Show Last 20 Lines