Page MenuHomePhabricator
Differential D8555

[web] rework metadata tests to use CommQueryExecutor
ClosedPublic
Actions

Authored by kamil on Jul 19 2023, 6:55 AM.
Tags
None
Referenced Files
F2176535: D8555.diff
Wed, Jul 3, 4:29 AM
F2169344: D8555.diff
Tue, Jul 2, 11:14 AM
Unknown Object (File)
Mon, Jul 1, 1:23 AM
Unknown Object (File)
Mon, Jul 1, 1:23 AM
Unknown Object (File)
Mon, Jul 1, 1:23 AM
Unknown Object (File)
Mon, Jul 1, 1:23 AM
Unknown Object (File)
Mon, Jul 1, 1:19 AM
Unknown Object (File)
Sat, Jun 29, 9:48 PM
View All 95 Files
Subscribers
ashoat

Details

Reviewers
michal
tomek
Commits
rCOMMcfb5ea11fd26: [web] rework metadata tests to use CommQueryExecutor
Summary

Updates test to new module

Depends on D8554

Test Plan

Run tests

Diff Detail

Repository
rCOMM Comm
Branch
wasm-publish
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jul 19 2023, 6:55 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 19 2023, 6:55 AM
kamil added a child revision: D8556: [web] rework draft tests to use CommQueryExecutor.Jul 19 2023, 6:56 AM
Harbormaster completed remote builds in B21034: Diff 28830.Jul 19 2023, 7:20 AM
kamil published this revision for review.Jul 19 2023, 9:05 AM
kamil added inline comments.
web/database/queries/metadata-queries.test.js
30

native getMetadata returns std::string always

michal accepted this revision.Jul 21 2023, 6:20 AM
This revision is now accepted and ready to land.Jul 21 2023, 6:20 AM
michal added inline comments.Jul 21 2023, 6:23 AM
web/database/queries/metadata-queries.test.js
42

Shouldn't we clear this metadata after the test?

kamil updated this revision to Diff 29003.Jul 25 2023, 2:08 AM

rebase

kamil added inline comments.Jul 25 2023, 2:21 AM
web/database/queries/metadata-queries.test.js
42

indeed, I think to make those tests valid we should delete the entire database after each test, I updated the whole stack to reflect this need

kamil mentioned this in D8557: [web] rework storage engine tests to use CommQueryExecutor.Jul 25 2023, 2:22 AM
Harbormaster failed remote builds in B21170: Diff 29003!Jul 25 2023, 2:46 AM
kamil updated this revision to Diff 29122.Jul 27 2023, 5:14 AM

rebase

This revision was landed with ongoing or failed builds.Jul 27 2023, 5:40 AM
Closed by commit rCOMMcfb5ea11fd26: [web] rework metadata tests to use CommQueryExecutor (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMcfb5ea11fd26: [web] rework metadata tests to use CommQueryExecutor.
Harbormaster failed remote builds in B21272: Diff 29122!Jul 27 2023, 5:59 AM

Revision Contents
Changeset List

PathSize
web/
database/
queries/
48 lines

Diff 28830

View Options

web/database/queries/metadata-queries.test.js

Loading...