Paths

Table of Contentst

[web] rework database module tests to use CommQueryExecutor
ClosedPublic
Actions

Authored by kamil on Jul 19 2023, 2:00 PM.

Details

Reviewers

michal
tomek

Commits

rCOMM1bc7a2637aeb: [web] rework database module tests to use CommQueryExecutor

Summary

Updates test to new module

Test Plan

Run tests

Diff Detail

Repository

rCOMM Comm

Branch

wasm-publish

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jul 19 2023, 2:00 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 19 2023, 2:00 PM

kamil added a child revision: D8559: [web] implement functions to import/export database content.Jul 19 2023, 2:02 PM

Harbormaster completed remote builds in B21037: Diff 28833.Jul 19 2023, 2:46 PM

kamil published this revision for review.Jul 19 2023, 4:07 PM

kamil added inline comments.

web/database/sql-js.test.js
29	no longer needed

michal accepted this revision.Jul 21 2023, 1:24 PM

This revision is now accepted and ready to land.Jul 21 2023, 1:24 PM

kamil mentioned this in D8611: [web] implement function to clear database content.Jul 25 2023, 9:01 AM

kamil removed a child revision: D8559: [web] implement functions to import/export database content.Jul 25 2023, 9:03 AM

add clearSensitiveData tests

kamil edited parent revisions, added: D8559: [web] implement functions to import/export database content; removed: D8557: [web] rework storage engine tests to use CommQueryExecutor.Jul 25 2023, 9:05 AM

kamil added a child revision: D8554: [web] rework report tests to use CommQueryExecutor.

added a new test so I would like to have another look from the reviewers

Harbormaster completed remote builds in B21168: Diff 29001.Jul 25 2023, 9:28 AM

Can we also check if the FILE_PATH contains no file (with module.FS.stat or sth)?

This revision is now accepted and ready to land.Jul 25 2023, 1:17 PM

kamil edited the summary of this revision. (Show Details)Jul 27 2023, 12:11 PM

add module.FS.stat test

Harbormaster completed remote builds in B21271: Diff 29121.Jul 27 2023, 12:30 PM

Closed by commit rCOMM1bc7a2637aeb: [web] rework database module tests to use CommQueryExecutor. · Explain WhyJul 27 2023, 12:39 PM

This revision was automatically updated to reflect the committed changes.

kamil mentioned this in rCOMM6bd9bba33bc9: [web] implement function to clear database content.

kamil added a commit: rCOMM1bc7a2637aeb: [web] rework database module tests to use CommQueryExecutor.

Revision Contents
Changeset List

Path

Size

web/

database/

db-module.test.js

11 lines

sql-js.test.js

Diff 28833

View Options

web/database/db-module.test.js