Page MenuHomePhabricator

[keyserver] Merge `fetchAll` and `fetchByID` functions
ClosedPublic

Authored by tomek on Aug 25 2023, 2:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 4:00 PM
Unknown Object (File)
Sun, Nov 10, 3:59 PM
Unknown Object (File)
Sun, Nov 10, 3:58 PM
Unknown Object (File)
Tue, Nov 5, 2:12 AM
Unknown Object (File)
Oct 2 2024, 6:40 PM
Unknown Object (File)
Oct 1 2024, 12:00 PM
Unknown Object (File)
Sep 27 2024, 1:16 PM
Unknown Object (File)
Sep 27 2024, 1:16 PM
Subscribers

Details

Summary

Instead of having two functions: ane which fetches all the entries and one which filters by id, we can have a single one which handles both cases. Additional benefit is that for current-user spec, we don't need to introduce en exception in spec's interface (we don't need to fetch current user by id).

https://linear.app/comm/issue/ENG-4631/migrate-checkstate-from-session-utils-to-a-spec

Depends on D8927

Test Plan

Modify keyserver db and check if the state get fixed.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable