Page MenuHomePhabricator
Differential D8948

[keyserver] Generalize state_check status handling using specs
ClosedPublic
Actions

Authored by tomek on Aug 25 2023, 5:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 1 2025, 3:24 PM
Unknown Object (File)
Mar 1 2025, 3:24 PM
Unknown Object (File)
Mar 1 2025, 3:23 PM
Unknown Object (File)
Mar 1 2025, 3:01 PM
Unknown Object (File)
Feb 26 2025, 12:25 PM
Unknown Object (File)
Feb 3 2025, 6:11 AM
Unknown Object (File)
Jan 25 2025, 2:05 AM
Unknown Object (File)
Jan 25 2025, 2:05 AM
View All 89 Files
Subscribers
ashoat

Details

Reviewers
kamil
bartek
inka
Commits
rCOMM09562b850b78: [keyserver] Generalize state_check status handling using specs
Summary

Instead of computing hash for each store by hand, iterate over specs and compute all the hashes for them.

https://linear.app/comm/issue/ENG-4631/migrate-checkstate-from-session-utils-to-a-spec

Depends on D8946

Test Plan

Bring back the old hash logic and compare the results with the new version.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 30577

View Options

keyserver/src/shared/state-sync/current-user-state-sync-spec.js

Show First 20 Lines • Show All 63 Lines • ▼ Show 20 Lines if (
this.props.mouseOverMessagePosition && this.props.mouseOverMessagePosition &&
this.props.mouseOverMessagePosition.item.messageInfo.id === id && this.props.mouseOverMessagePosition.item.messageInfo.id === id &&
sidebarExistsOrCanBeCreated sidebarExistsOrCanBeCreated
) { ) {
messageActionTooltip = ( messageActionTooltip = (
<MessageActionButtons <MessageActionButtons
threadInfo={threadInfo} threadInfo={threadInfo}
item={item} item={item}
containerPosition={ mouseOverMessagePosition={this.props.mouseOverMessagePosition}
this.props.mouseOverMessagePosition.containerPosition
}
availableTooltipPositions={availableTooltipPositionsForRobotext} availableTooltipPositions={availableTooltipPositionsForRobotext}
/> />
); );
} }
let messageActionLinks; let messageActionLinks;
if (messageActionTooltip) { if (messageActionTooltip) {
messageActionLinks = ( messageActionLinks = (
▲ Show 20 Lines • Show All 140 Lines • Show Last 20 Lines
View Options

keyserver/src/shared/state-sync/entries-state-sync-spec.js

Show First 20 Lines • Show All 63 Lines • ▼ Show 20 Lines if (
this.props.mouseOverMessagePosition && this.props.mouseOverMessagePosition &&
this.props.mouseOverMessagePosition.item.messageInfo.id === id && this.props.mouseOverMessagePosition.item.messageInfo.id === id &&
sidebarExistsOrCanBeCreated sidebarExistsOrCanBeCreated
) { ) {
messageActionTooltip = ( messageActionTooltip = (
<MessageActionButtons <MessageActionButtons
threadInfo={threadInfo} threadInfo={threadInfo}
item={item} item={item}
containerPosition={ mouseOverMessagePosition={this.props.mouseOverMessagePosition}
this.props.mouseOverMessagePosition.containerPosition
}
availableTooltipPositions={availableTooltipPositionsForRobotext} availableTooltipPositions={availableTooltipPositionsForRobotext}
/> />
); );
} }
let messageActionLinks; let messageActionLinks;
if (messageActionTooltip) { if (messageActionTooltip) {
messageActionLinks = ( messageActionLinks = (
▲ Show 20 Lines • Show All 140 Lines • Show Last 20 Lines
View Options

keyserver/src/shared/state-sync/state-sync-spec.js

Show First 20 Lines • Show All 63 Lines • ▼ Show 20 Lines if (
this.props.mouseOverMessagePosition && this.props.mouseOverMessagePosition &&
this.props.mouseOverMessagePosition.item.messageInfo.id === id && this.props.mouseOverMessagePosition.item.messageInfo.id === id &&
sidebarExistsOrCanBeCreated sidebarExistsOrCanBeCreated
) { ) {
messageActionTooltip = ( messageActionTooltip = (
<MessageActionButtons <MessageActionButtons
threadInfo={threadInfo} threadInfo={threadInfo}
item={item} item={item}
containerPosition={ mouseOverMessagePosition={this.props.mouseOverMessagePosition}
this.props.mouseOverMessagePosition.containerPosition
}
availableTooltipPositions={availableTooltipPositionsForRobotext} availableTooltipPositions={availableTooltipPositionsForRobotext}
/> />
); );
} }
let messageActionLinks; let messageActionLinks;
if (messageActionTooltip) { if (messageActionTooltip) {
messageActionLinks = ( messageActionLinks = (
▲ Show 20 Lines • Show All 140 Lines • Show Last 20 Lines
View Options

keyserver/src/shared/state-sync/threads-state-sync-spec.js

Show First 20 Lines • Show All 63 Lines • ▼ Show 20 Lines if (
this.props.mouseOverMessagePosition && this.props.mouseOverMessagePosition &&
this.props.mouseOverMessagePosition.item.messageInfo.id === id && this.props.mouseOverMessagePosition.item.messageInfo.id === id &&
sidebarExistsOrCanBeCreated sidebarExistsOrCanBeCreated
) { ) {
messageActionTooltip = ( messageActionTooltip = (
<MessageActionButtons <MessageActionButtons
threadInfo={threadInfo} threadInfo={threadInfo}
item={item} item={item}
containerPosition={ mouseOverMessagePosition={this.props.mouseOverMessagePosition}
this.props.mouseOverMessagePosition.containerPosition
}
availableTooltipPositions={availableTooltipPositionsForRobotext} availableTooltipPositions={availableTooltipPositionsForRobotext}
/> />
); );
} }
let messageActionLinks; let messageActionLinks;
if (messageActionTooltip) { if (messageActionTooltip) {
messageActionLinks = ( messageActionLinks = (
▲ Show 20 Lines • Show All 140 Lines • Show Last 20 Lines
View Options

keyserver/src/shared/state-sync/users-state-sync-spec.js

Loading...
View Options

keyserver/src/socket/session-utils.js

Loading...