Page MenuHomePhabricator

[keyserver] Simplify fetching threads
ClosedPublic

Authored by tomek on Aug 25 2023, 3:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 4:00 PM
Unknown Object (File)
Sun, Nov 10, 4:00 PM
Unknown Object (File)
Sun, Nov 10, 4:00 PM
Unknown Object (File)
Sun, Nov 10, 3:58 PM
Unknown Object (File)
Tue, Nov 5, 2:12 AM
Unknown Object (File)
Fri, Oct 18, 2:40 AM
Unknown Object (File)
Oct 4 2024, 2:11 AM
Unknown Object (File)
Sep 27 2024, 1:16 PM
Subscribers

Details

Summary

All the other fetchers return a collection directly without intermediate object - we can do the same for threads so that the code becomes simpler and more simplifications could be made further in the stack.

https://linear.app/comm/issue/ENG-4654/unify-interfaces-in-session-utils

Depends on D8941

Test Plan

Modify threads in the keyserver db and check if the state is correctly fixed.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek requested review of this revision.Aug 25 2023, 4:02 AM
bartek added inline comments.
keyserver/src/shared/state-sync/threads-state-sync-spec.js
19–26 ↗(On Diff #30310)

I find it more readable

This revision is now accepted and ready to land.Aug 25 2023, 7:22 AM

Simplify thread state sync spec

keyserver/src/shared/state-sync/threads-state-sync-spec.js
19–26 ↗(On Diff #30310)

Makes sense!

This revision was automatically updated to reflect the committed changes.