Paths

Table of Contentst

-
lib/selectors/
-
selectors/
-
socket-selectors.js

Differential D9031

[lib] Use specs to determine hash value for top-level infos
ClosedPublic
Actions

Authored by tomek on Aug 30 2023, 9:41 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Mar 18, 6:35 PM

	Unknown Object (File)
	Mon, Mar 10, 10:51 PM

	Unknown Object (File)
	Mar 1 2025, 3:25 PM

	Unknown Object (File)
	Mar 1 2025, 3:25 PM

	Unknown Object (File)
	Mar 1 2025, 3:23 PM

	Unknown Object (File)
	Mar 1 2025, 3:00 PM

	Unknown Object (File)
	Jan 25 2025, 2:05 AM

	Unknown Object (File)
	Jan 25 2025, 2:05 AM

View All 99 Files

Subscribers

Details

Reviewers

kamil
bartek
inka

Commits

rCOMM5daaf661b987: [lib] Use specs to determine hash value for top-level infos

Summary

Create convertedInfos where hashKeys are used as keys and access this object to determine for which entries we should compute a hash.

https://linear.app/comm/issue/ENG-4813/migrate-getclientresponsesselector-to-a-spec

Depends on D9030

Test Plan

Modify server state and check if state check fixes client state.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Aug 30 2023, 9:41 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 30 2023, 9:41 AM

Harbormaster completed remote builds in B22275: Diff 30584.Aug 30 2023, 9:59 AM

tomek requested review of this revision.Aug 30 2023, 9:59 AM

bartek accepted this revision.Aug 31 2023, 12:34 AM

This revision is now accepted and ready to land.Aug 31 2023, 12:34 AM

tomek added a child revision: D9048: [lib] Use specs to determine hash value for inner infos.Aug 31 2023, 7:23 AM

Closed by commit rCOMM5daaf661b987: [lib] Use specs to determine hash value for top-level infos (authored by tomek). · Explain WhySep 5 2023, 7:03 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM5daaf661b987: [lib] Use specs to determine hash value for top-level infos.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

socket-selectors.js

70 lines

Diff 30766

lib/selectors/socket-selectors.js

	Show First 20 Lines • Show All 63 Lines • ▼ Show 20 Lines		if (
	this.props.mouseOverMessagePosition &&			this.props.mouseOverMessagePosition &&
	this.props.mouseOverMessagePosition.item.messageInfo.id === id &&			this.props.mouseOverMessagePosition.item.messageInfo.id === id &&
	sidebarExistsOrCanBeCreated			sidebarExistsOrCanBeCreated
	) {			) {
	messageActionTooltip = (			messageActionTooltip = (
	<MessageActionButtons			<MessageActionButtons
	threadInfo={threadInfo}			threadInfo={threadInfo}
	item={item}			item={item}
	containerPosition={			mouseOverMessagePosition={this.props.mouseOverMessagePosition}
	this.props.mouseOverMessagePosition.containerPosition
	}
	availableTooltipPositions={availableTooltipPositionsForRobotext}			availableTooltipPositions={availableTooltipPositionsForRobotext}
	/>			/>
	);			);
	}			}

	let messageActionLinks;			let messageActionLinks;
	if (messageActionTooltip) {			if (messageActionTooltip) {
	messageActionLinks = (			messageActionLinks = (
	▲ Show 20 Lines • Show All 140 Lines • Show Last 20 Lines