Paths

Table of Contentst

-
keyserver/src/
-
src/
-
creators/
-
update-creator.js
-
fetchers/
1/2
entry-fetchers.js
-
socket/
1/2
session-utils.js

[keyserver] Use Set as an argument of fetchEntryInfosByID
ClosedPublic
Actions

Authored by tomek on Aug 23 2023, 6:16 AM.

Details

Reviewers

kamil
bartek
inka

Commits

rCOMMba61fbfe7ae9: [keyserver] Use Set as an argument of fetchEntryInfosByID

Summary

Refactor fetchEntryInfosByID so that it accepts a set of ids. Something similar could be done for fetchKnownUserInfos but it is used in a lot of places so it would be expensive.
Also, replace ids arrays with sets in checkState - that makes sense on its own, but also is beneficial because it makes interfaces of specs more unified.

https://linear.app/comm/issue/ENG-4654/unify-interfaces-in-session-utils

Test Plan

Change some entries and users in the keyserver db, increase state check frequency, start the app and check if the state got fixed.
Add console logs in fetchEntryInfosByID and check if the correct result is returned.
Check if correct data is fetched in checkState.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Aug 23 2023, 6:16 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 23 2023, 6:16 AM

tomek added a child revision: D8926: [keyserver] Return object from fetchEntryInfosByID.Aug 23 2023, 6:33 AM

Harbormaster completed remote builds in B22036: Diff 30252.Aug 23 2023, 6:35 AM

tomek requested review of this revision.Aug 23 2023, 6:35 AM

LGTM

This revision is now accepted and ready to land.Aug 23 2023, 12:35 PM

kamil accepted this revision.Aug 24 2023, 2:43 PM

Closed by commit rCOMMba61fbfe7ae9: [keyserver] Use Set as an argument of fetchEntryInfosByID (authored by tomek). · Explain WhyAug 30 2023, 9:16 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMba61fbfe7ae9: [keyserver] Use Set as an argument of fetchEntryInfosByID.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

update-creator.js

7 lines

fetchers/

entry-fetchers.js

8 lines

socket/

session-utils.js

14 lines

Diff 30573

View Options

keyserver/src/creators/update-creator.js

	Show All 21 Lines
	a {			a {
	text-decoration: none;			text-decoration: none;
	color: #2a5db0;			color: #2a5db0;
	}			}
	img,			img,
	iframe {			iframe {
	display: block;			display: block;
	}			}
	input[type='text'],			input[type='text'],
	input[type='password'],			input[type='password'],
	textarea {			textarea {
	atulUnsubmitted Not Done Inline Actions Moving the global input styling and moving it to the input component. Then why are we keeping styles like `border` and `border-radius`? Don't these styles also affect the `<textarea>` tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for `input` and another for `textarea`)? atul: > Moving the global input styling and moving it to the input component. Then why are we…
	benschacAuthorUnsubmitted Done Inline Actions Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect `textarea` elements. benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
	-webkit-appearance: none;
	-moz-appearance: none;
	-webkit-border-radius: 0;
	border: 1px solid #dddddd;			border: 1px solid #dddddd;
	border-radius: 1px;			border-radius: 1px;
	font-family: var(--font-stack);			font-family: var(--font-stack);
	}			}
	:global(#react-root) {			:global(#react-root) {
	display: flex;			display: flex;
	flex-direction: column;			flex-direction: column;
	height: 100%;			height: 100%;
	▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines

View Options

keyserver/src/fetchers/entry-fetchers.js

	Show All 21 Lines
	a {			a {
	text-decoration: none;			text-decoration: none;
	color: #2a5db0;			color: #2a5db0;
	}			}
	img,			img,
	iframe {			iframe {
	display: block;			display: block;
	}			}
	input[type='text'],			input[type='text'],
	input[type='password'],			input[type='password'],
	textarea {			textarea {
	atulUnsubmitted Not Done Inline Actions Moving the global input styling and moving it to the input component. Then why are we keeping styles like `border` and `border-radius`? Don't these styles also affect the `<textarea>` tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for `input` and another for `textarea`)? atul: > Moving the global input styling and moving it to the input component. Then why are we…
	benschacAuthorUnsubmitted Done Inline Actions Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect `textarea` elements. benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
	-webkit-appearance: none;
	-moz-appearance: none;
	-webkit-border-radius: 0;
	border: 1px solid #dddddd;			border: 1px solid #dddddd;
	border-radius: 1px;			border-radius: 1px;
	font-family: var(--font-stack);			font-family: var(--font-stack);
	}			}
	:global(#react-root) {			:global(#react-root) {
	display: flex;			display: flex;
	flex-direction: column;			flex-direction: column;
	height: 100%;			height: 100%;
	▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines

View Options

keyserver/src/socket/session-utils.js

	Show All 21 Lines
	a {			a {
	text-decoration: none;			text-decoration: none;
	color: #2a5db0;			color: #2a5db0;
	}			}
	img,			img,
	iframe {			iframe {
	display: block;			display: block;
	}			}
	input[type='text'],			input[type='text'],
	input[type='password'],			input[type='password'],
	textarea {			textarea {
	atulUnsubmitted Not Done Inline Actions Moving the global input styling and moving it to the input component. Then why are we keeping styles like `border` and `border-radius`? Don't these styles also affect the `<textarea>` tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for `input` and another for `textarea`)? atul: > Moving the global input styling and moving it to the input component. Then why are we…
	benschacAuthorUnsubmitted Done Inline Actions Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect `textarea` elements. benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
	-webkit-appearance: none;
	-moz-appearance: none;
	-webkit-border-radius: 0;
	border: 1px solid #dddddd;			border: 1px solid #dddddd;
	border-radius: 1px;			border-radius: 1px;
	font-family: var(--font-stack);			font-family: var(--font-stack);
	}			}
	:global(#react-root) {			:global(#react-root) {
	display: flex;			display: flex;
	flex-direction: column;			flex-direction: column;
	height: 100%;			height: 100%;
	▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines

[keyserver] Use Set as an argument of fetchEntryInfosByIDClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30573

keyserver/src/creators/update-creator.js

keyserver/src/fetchers/entry-fetchers.js

keyserver/src/socket/session-utils.js

[keyserver] Use Set as an argument of fetchEntryInfosByID
ClosedPublic
Actions

Revision Contents
Changeset List