Page MenuHomePhabricator

[keyserver] Use Set as an argument of fetchEntryInfosByID
ClosedPublic

Authored by tomek on Aug 23 2023, 6:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 3:59 PM
Unknown Object (File)
Sun, Nov 10, 3:59 PM
Unknown Object (File)
Sun, Nov 10, 3:58 PM
Unknown Object (File)
Tue, Nov 5, 2:12 AM
Unknown Object (File)
Sep 27 2024, 1:16 PM
Unknown Object (File)
Sep 27 2024, 1:16 PM
Unknown Object (File)
Sep 27 2024, 1:15 PM
Unknown Object (File)
Sep 27 2024, 1:01 PM
Subscribers

Details

Summary

Refactor fetchEntryInfosByID so that it accepts a set of ids. Something similar could be done for fetchKnownUserInfos but it is used in a lot of places so it would be expensive.
Also, replace ids arrays with sets in checkState - that makes sense on its own, but also is beneficial because it makes interfaces of specs more unified.

https://linear.app/comm/issue/ENG-4654/unify-interfaces-in-session-utils

Test Plan

Change some entries and users in the keyserver db, increase state check frequency, start the app and check if the state got fixed.
Add console logs in fetchEntryInfosByID and check if the correct result is returned.
Check if correct data is fetched in checkState.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable