Page MenuHomePhabricator
Differential D9008

[keyserver] Determine which infos to send based on specs
ClosedPublic
Actions

Authored by tomek on Aug 29 2023, 6:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 1 2025, 3:24 PM
Unknown Object (File)
Mar 1 2025, 3:24 PM
Unknown Object (File)
Mar 1 2025, 3:23 PM
Unknown Object (File)
Mar 1 2025, 3:01 PM
Unknown Object (File)
Feb 11 2025, 4:45 PM
Unknown Object (File)
Jan 25 2025, 2:05 AM
Unknown Object (File)
Jan 25 2025, 2:05 AM
Unknown Object (File)
Jan 25 2025, 2:04 AM
View All 98 Files
Subscribers
ashoat

Details

Reviewers
kamil
bartek
inka
Commits
rCOMM539ed8b32c7e: [keyserver] Determine which infos to send based on specs
Summary

Define a new prop in a spec where we describe which keys are used when sending delete or new infos. The only complicated state to sync is userInfos because it contains an additional delete condition - when a user no longer has a name.

https://linear.app/comm/issue/ENG-4631/migrate-checkstate-from-session-utils-to-a-spec

Depends on D8979

Test Plan

Modify keyserver db and check if the store get fixed (including editing, inserting and deleting infos).

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
shared/
state-sync/
6 lines
9 lines
6 lines
38 lines
socket/
72 lines

Diff 30582

View Options

keyserver/src/shared/state-sync/entries-state-sync-spec.js

Show First 20 Lines • Show All 63 Lines • ▼ Show 20 Lines if (
this.props.mouseOverMessagePosition && this.props.mouseOverMessagePosition &&
this.props.mouseOverMessagePosition.item.messageInfo.id === id && this.props.mouseOverMessagePosition.item.messageInfo.id === id &&
sidebarExistsOrCanBeCreated sidebarExistsOrCanBeCreated
) { ) {
messageActionTooltip = ( messageActionTooltip = (
<MessageActionButtons <MessageActionButtons
threadInfo={threadInfo} threadInfo={threadInfo}
item={item} item={item}
containerPosition={ mouseOverMessagePosition={this.props.mouseOverMessagePosition}
this.props.mouseOverMessagePosition.containerPosition
}
availableTooltipPositions={availableTooltipPositionsForRobotext} availableTooltipPositions={availableTooltipPositionsForRobotext}
/> />
); );
} }
let messageActionLinks; let messageActionLinks;
if (messageActionTooltip) { if (messageActionTooltip) {
messageActionLinks = ( messageActionLinks = (
▲ Show 20 Lines • Show All 140 Lines • Show Last 20 Lines
View Options

keyserver/src/shared/state-sync/state-sync-spec.js

Show First 20 Lines • Show All 63 Lines • ▼ Show 20 Lines if (
this.props.mouseOverMessagePosition && this.props.mouseOverMessagePosition &&
this.props.mouseOverMessagePosition.item.messageInfo.id === id && this.props.mouseOverMessagePosition.item.messageInfo.id === id &&
sidebarExistsOrCanBeCreated sidebarExistsOrCanBeCreated
) { ) {
messageActionTooltip = ( messageActionTooltip = (
<MessageActionButtons <MessageActionButtons
threadInfo={threadInfo} threadInfo={threadInfo}
item={item} item={item}
containerPosition={ mouseOverMessagePosition={this.props.mouseOverMessagePosition}
this.props.mouseOverMessagePosition.containerPosition
}
availableTooltipPositions={availableTooltipPositionsForRobotext} availableTooltipPositions={availableTooltipPositionsForRobotext}
/> />
); );
} }
let messageActionLinks; let messageActionLinks;
if (messageActionTooltip) { if (messageActionTooltip) {
messageActionLinks = ( messageActionLinks = (
▲ Show 20 Lines • Show All 140 Lines • Show Last 20 Lines
View Options

keyserver/src/shared/state-sync/threads-state-sync-spec.js

Show First 20 Lines • Show All 63 Lines • ▼ Show 20 Lines if (
this.props.mouseOverMessagePosition && this.props.mouseOverMessagePosition &&
this.props.mouseOverMessagePosition.item.messageInfo.id === id && this.props.mouseOverMessagePosition.item.messageInfo.id === id &&
sidebarExistsOrCanBeCreated sidebarExistsOrCanBeCreated
) { ) {
messageActionTooltip = ( messageActionTooltip = (
<MessageActionButtons <MessageActionButtons
threadInfo={threadInfo} threadInfo={threadInfo}
item={item} item={item}
containerPosition={ mouseOverMessagePosition={this.props.mouseOverMessagePosition}
this.props.mouseOverMessagePosition.containerPosition
}
availableTooltipPositions={availableTooltipPositionsForRobotext} availableTooltipPositions={availableTooltipPositionsForRobotext}
/> />
); );
} }
let messageActionLinks; let messageActionLinks;
if (messageActionTooltip) { if (messageActionTooltip) {
messageActionLinks = ( messageActionLinks = (
▲ Show 20 Lines • Show All 140 Lines • Show Last 20 Lines
View Options

keyserver/src/shared/state-sync/users-state-sync-spec.js

Show First 20 Lines • Show All 63 Lines • ▼ Show 20 Lines if (
this.props.mouseOverMessagePosition && this.props.mouseOverMessagePosition &&
this.props.mouseOverMessagePosition.item.messageInfo.id === id && this.props.mouseOverMessagePosition.item.messageInfo.id === id &&
sidebarExistsOrCanBeCreated sidebarExistsOrCanBeCreated
) { ) {
messageActionTooltip = ( messageActionTooltip = (
<MessageActionButtons <MessageActionButtons
threadInfo={threadInfo} threadInfo={threadInfo}
item={item} item={item}
containerPosition={ mouseOverMessagePosition={this.props.mouseOverMessagePosition}
this.props.mouseOverMessagePosition.containerPosition
}
availableTooltipPositions={availableTooltipPositionsForRobotext} availableTooltipPositions={availableTooltipPositionsForRobotext}
/> />
); );
} }
let messageActionLinks; let messageActionLinks;
if (messageActionTooltip) { if (messageActionTooltip) {
messageActionLinks = ( messageActionLinks = (
▲ Show 20 Lines • Show All 140 Lines • Show Last 20 Lines
View Options

keyserver/src/socket/session-utils.js

Loading...