Page MenuHomePhabricator

[keyserver] Remove old current user info
ClosedPublic

Authored by michal on Sep 8 2023, 7:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 11:35 PM
Unknown Object (File)
Sun, Dec 15, 11:35 PM
Unknown Object (File)
Sun, Dec 15, 11:34 PM
Unknown Object (File)
Sun, Dec 15, 11:28 PM
Unknown Object (File)
Wed, Dec 11, 9:41 AM
Unknown Object (File)
Nov 8 2024, 12:27 AM
Unknown Object (File)
Nov 8 2024, 12:27 AM
Unknown Object (File)
Nov 8 2024, 12:08 AM
Subscribers

Details

Summary

ENG-4850
Depends on D9110
We can remove old current user info and simplify the code. Reasoning copied from the task:

  1. As you can see in D1463 when OldCurrentUserInfo the version was 86, while our current minimal supported version is 128
  2. fetchCurrentUserInfo uses fetchLoggedInUserInfo, which if you look at the code, never actually creates OldCurrentUserInfo structure, it always created the newer type
  3. Other code always uses fetchCurrentUserInfo as the source of truth so we can also change their signatures
Test Plan

yarn flow, analyze all changes and make sure that all data is in the end fetched using fetchCurrentUserInfo or from the clients

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lib/types/socket-types.js
193–211 ↗(On Diff #30867)

It seems that ClientFullStateSync and ServerFullStateSync are the same now and it might be a good idea to merge them. On the other hand, these types might become different again in the future.

michal requested review of this revision.Sep 8 2023, 7:52 AM

LGTM but letting other reviewers take a look

This revision is now accepted and ready to land.Sep 11 2023, 5:32 AM