Page MenuHomePhabricator
Differential D9147

[lib/web/native] Improve conversion utils
ClosedPublic
Actions

Authored by michal on Sep 12 2023, 5:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 11:11 AM
Unknown Object (File)
Fri, Nov 8, 12:51 AM
Unknown Object (File)
Fri, Nov 8, 12:51 AM
Unknown Object (File)
Fri, Nov 8, 12:50 AM
Unknown Object (File)
Thu, Nov 7, 8:05 PM
Unknown Object (File)
Mon, Oct 28, 10:52 AM
Unknown Object (File)
Sep 28 2024, 7:35 PM
Unknown Object (File)
Sep 28 2024, 7:35 PM
View All 60 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
inka
atul
Commits
rCOMM375b9a2daeff: [lib/web/native] Improve conversion utils
Summary

Improve the conversion utils situation for the future diffs:

  1. Rename convertNotificationThreadIDToNewIDSchema to convertNonPendingIDToNewSchema and add idPrefix param instead of always using ashoats id
  2. Add convertIDToNewSchema and use it inside convertDraftKeyToNewIDSchema
Test Plan

yarn flow-all to test (1)
yarn jest-all to test (2) -> draft migration tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
utils/
50 lines
native/
push/
8 lines
8 lines
9 lines
web/
push-notif/
9 lines
6 lines

Diff 31303

View Options

lib/utils/migration-utils.js

Loading...
View Options

native/push/android.js

Loading...
View Options

native/push/comm-ios-notification.js

Loading...
View Options

native/push/push-handler.react.js

Loading...
View Options

web/push-notif/push-notifs-handler.js

Loading...
View Options

web/push-notif/service-worker.js

Loading...