Page MenuHomePhabricator
Differential D9147

[lib/web/native] Improve conversion utils
ClosedPublic
Actions

Authored by michal on Sep 12 2023, 5:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 9, 9:14 AM
Unknown Object (File)
Wed, Apr 9, 12:50 AM
Unknown Object (File)
Tue, Apr 8, 11:16 PM
Unknown Object (File)
Tue, Apr 8, 8:42 PM
Unknown Object (File)
Mon, Apr 7, 8:40 AM
Unknown Object (File)
Thu, Apr 3, 9:41 AM
Unknown Object (File)
Sun, Mar 23, 3:59 AM
Unknown Object (File)
Wed, Mar 19, 2:22 PM
View All 86 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
inka
atul
Commits
rCOMM375b9a2daeff: [lib/web/native] Improve conversion utils
Summary

Improve the conversion utils situation for the future diffs:

  1. Rename convertNotificationThreadIDToNewIDSchema to convertNonPendingIDToNewSchema and add idPrefix param instead of always using ashoats id
  2. Add convertIDToNewSchema and use it inside convertDraftKeyToNewIDSchema
Test Plan

yarn flow-all to test (1)
yarn jest-all to test (2) -> draft migration tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
utils/
50 lines
native/
push/
8 lines
8 lines
9 lines
web/
push-notif/
9 lines
6 lines

Diff 31303

View Options

lib/utils/migration-utils.js

Show All 14 Linesexport const DB_SUPPORTED_OS: $ReadOnlyArray<string> = [
'Linux', 'Linux',
'Mac OS', 'Mac OS',
]; ];
export const DB_SUPPORTED_BROWSERS: $ReadOnlyArray<string> = [ export const DB_SUPPORTED_BROWSERS: $ReadOnlyArray<string> = [
'edge', 'edge',
'edge-chromium', 'edge-chromium',
'chrome', 'chrome',
'safari',
'firefox', 'firefox',
'opera', 'opera',
]; ];
View Options

native/push/android.js

Show All 14 Linesexport const DB_SUPPORTED_OS: $ReadOnlyArray<string> = [
'Linux', 'Linux',
'Mac OS', 'Mac OS',
]; ];
export const DB_SUPPORTED_BROWSERS: $ReadOnlyArray<string> = [ export const DB_SUPPORTED_BROWSERS: $ReadOnlyArray<string> = [
'edge', 'edge',
'edge-chromium', 'edge-chromium',
'chrome', 'chrome',
'safari',
'firefox', 'firefox',
'opera', 'opera',
]; ];
View Options

native/push/comm-ios-notification.js

Show All 14 Linesexport const DB_SUPPORTED_OS: $ReadOnlyArray<string> = [
'Linux', 'Linux',
'Mac OS', 'Mac OS',
]; ];
export const DB_SUPPORTED_BROWSERS: $ReadOnlyArray<string> = [ export const DB_SUPPORTED_BROWSERS: $ReadOnlyArray<string> = [
'edge', 'edge',
'edge-chromium', 'edge-chromium',
'chrome', 'chrome',
'safari',
'firefox', 'firefox',
'opera', 'opera',
]; ];
View Options

native/push/push-handler.react.js

Show All 14 Linesexport const DB_SUPPORTED_OS: $ReadOnlyArray<string> = [
'Linux', 'Linux',
'Mac OS', 'Mac OS',
]; ];
export const DB_SUPPORTED_BROWSERS: $ReadOnlyArray<string> = [ export const DB_SUPPORTED_BROWSERS: $ReadOnlyArray<string> = [
'edge', 'edge',
'edge-chromium', 'edge-chromium',
'chrome', 'chrome',
'safari',
'firefox', 'firefox',
'opera', 'opera',
]; ];
View Options

web/push-notif/push-notifs-handler.js

Loading...
View Options

web/push-notif/service-worker.js

Loading...