Details
Details
Navigated to:
- http://localhost:3000/comm/chat/thread/256%7C91890/ and http://localhost:3000/comm/chat/thread/91890/ -> web app opened correct thread
- http://localhost:3000/comm/chat/thread/pending/sidebar/256%7C91894/ and http://localhost:3000/comm/chat/thread/pending/sidebar/91894/ -> the keyserver doesn't support navigating to pending threads right now, so the web app opened on the most recent thread, but there were no error
- http://localhost:3000/comm/chat/thread/new/83884+86227/ -> web app opened on the chat creation menu with the selected users
- http://localhost:3000/comm/settings/account/ -> web app opened on settings
Also run yarn jest
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
lib/utils/conversion-utils.js | ||
---|---|---|
35 ↗ | (On Diff #30966) | Nit: Would prefer using template literal instead of + operator to concatenate strings |
42–54 ↗ | (On Diff #30966) | Could we go with something like if (!pendingIDContents) { throw new Error('invalid_client_id_prefix'); } if (!pendingIDContents.sourceMessageID) { return id; } return getPendingThreadID( pendingIDContents.threadType, pendingIDContents.memberIDs, pendingIDContents.sourceMessageID.substring(prefix.length), ); to reduce indentation and improve readability? |