Details
Details
- Reviewers
kamil inka atul tomek - Commits
- rCOMMdd9055f2f3ab: [web] Migrate drafts to db for everyone
Tested on chromium:
- [on master] Replaced code in isSQLiteSupported:
return false; // <- added if (!isDev && (!currentLoggedInUserID || !isStaff(currentLoggedInUserID))) { return false; }
- logged in, made sure that there is persist:root in local storage, created a draft, closed the web page
- [Applied this diff] opened the web page, and checked if the draft are still there
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Instead of removing the previous migration, make it noop.
The reason why we can ignore this migration is because either:
- user is a staff user and we can assume that most staff users are already on version >= 2
- I don't think it's worth handling the edge case of staff users still on version 1
- user is not a staff user, in which case the migration was a noop anyway
- (but after changes in previous diffs, the database would be supported and so this migration would run, incorrectly)