[web/keyserver] Handle different thread ids in url
ClosedPublic
Actions

Authored by michal on Sep 12 2023, 5:36 AM.

Details

Reviewers

kamil
inka
atul

Commits

rCOMM343bd71fd30c: [web/keyserver] Handle different thread ids in url

Summary

ENG-4752
Depends on D9147
Depends on D9146

We want to handle older links too. Previously the server just ignored errors if the link couldn't be converted (so e.g. it contained older ids). Now we convert the ids in the urlinfo to the new schema on the client and server always tries to convert them.

Test Plan

Navigated to:

http://localhost:3000/comm/chat/thread/256%7C91890/ and http://localhost:3000/comm/chat/thread/91890/ -> web app opened correct thread
http://localhost:3000/comm/chat/thread/pending/sidebar/256%7C91894/ and http://localhost:3000/comm/chat/thread/pending/sidebar/91894/ -> the keyserver doesn't support navigating to pending threads right now, so the web app opened on the most recent thread, but there were no error
http://localhost:3000/comm/chat/thread/new/83884+86227/ -> web app opened on the chat creation menu with the selected users
http://localhost:3000/comm/settings/account/ -> web app opened on settings

Also run yarn jest

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Sep 12 2023, 5:36 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 12 2023, 5:36 AM

Harbormaster completed remote builds in B22528: Diff 30966.Sep 12 2023, 5:54 AM

michal requested review of this revision.Sep 12 2023, 5:54 AM

atul accepted this revision.Sep 14 2023, 9:46 AM

atul added inline comments.

lib/utils/conversion-utils.js

35 ↗

(On Diff #30966)

Nit: Would prefer using template literal instead of + operator to concatenate strings

42–54 ↗

(On Diff #30966)

Could we go with something like

if (!pendingIDContents) {
  throw new Error('invalid_client_id_prefix');
}

if (!pendingIDContents.sourceMessageID) {
  return id;
}

return getPendingThreadID(
  pendingIDContents.threadType,
  pendingIDContents.memberIDs,
  pendingIDContents.sourceMessageID.substring(prefix.length),
);

to reduce indentation and improve readability?

This revision is now accepted and ready to land.Sep 14 2023, 9:46 AM

Fixes

Harbormaster completed remote builds in B22659: Diff 31175.Sep 15 2023, 6:52 AM

Closed by commit rCOMM343bd71fd30c: [web/keyserver] Handle different thread ids in url (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhySep 20 2023, 2:28 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM343bd71fd30c: [web/keyserver] Handle different thread ids in url.