Page MenuHomePhabricator
Differential D9310

[Commtest] extract code to create a socket session with Tunnelbroker
ClosedPublic
Actions

Authored by kamil on Sep 28 2023, 7:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 2, 9:03 AM
Unknown Object (File)
Wed, Oct 2, 9:03 AM
Unknown Object (File)
Wed, Oct 2, 8:55 AM
Unknown Object (File)
Wed, Oct 2, 6:02 AM
Unknown Object (File)
Tue, Sep 17, 10:50 PM
Unknown Object (File)
Aug 25 2024, 12:15 PM
Unknown Object (File)
Aug 25 2024, 12:15 PM
Unknown Object (File)
Aug 25 2024, 12:09 PM
View All 53 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
bartek
varun
• jon
Commits
rCOMMd4c626324cb8: [Commtest] extract code to create a socket session with Tunnelbroker
Summary

Minor cleanup, putting duplicated code in one place - helps me with testing.

Test Plan
  1. Run Identity
  2. Run Tunnelbroker
  3. Go to commtest/
  4. Run:
cargo test --test identity_tunnelbroker_tests -- --nocapture
  1. Run:
cargo test --test tunnelbroker_integration_test -- --nocapture

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Sep 28 2023, 7:23 AM
kamil held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptSep 28 2023, 7:23 AM
Herald added subscribers: tomek, ashoat. · View Herald Transcript
kamil added a child revision: D9311: [Commtest] fix Clippy warnings and typos.Sep 28 2023, 7:29 AM
Harbormaster completed remote builds in B22889: Diff 31520.Sep 28 2023, 7:41 AM
kamil published this revision for review.Sep 28 2023, 8:08 AM
bartek accepted this revision.Sep 29 2023, 12:58 AM
bartek added inline comments.
services/commtest/src/tunnelbroker/socket.rs
11 ↗(On Diff #31520)

we could optionally make this configurable, we use env vars like COMM_SERVICES_PORT_BACKUP for other services

This revision is now accepted and ready to land.Sep 29 2023, 12:58 AM
michal accepted this revision.Sep 29 2023, 1:57 AM
kamil added inline comments.Oct 11 2023, 7:11 AM
services/commtest/src/tunnelbroker/socket.rs
11 ↗(On Diff #31520)

There is no env associated with WebSocket yet, created a task: ENG-5230

Closed by commit rCOMMd4c626324cb8: [Commtest] extract code to create a socket session with Tunnelbroker (authored by kamil). · Explain WhyOct 11 2023, 7:39 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMd4c626324cb8: [Commtest] extract code to create a socket session with Tunnelbroker.

Revision Contents
Changeset List

PathSize
services/
commtest/
src/
tunnelbroker/
2 lines
34 lines
tests/
76 lines
53 lines

Diff 31934

View Options

services/commtest/src/tunnelbroker/mod.rs

Loading...
View Options

services/commtest/src/tunnelbroker/socket.rs

Loading...
View Options

services/commtest/tests/identity_tunnelbroker_tests.rs

Loading...
View Options

services/commtest/tests/tunnelbroker_integration_test.rs

Loading...