- We need to make sure that each message is delivered to client.
- We need to persist it immediately after receiving
- Message will be removed after confirmation from client
Depends on D9314
Details
Details
- Restart RabbitMQ
- Restart localstack
- Run this code:
#[tokio::test]
async fn send_websocket() {
let device_info = create_device(None).await;
let mut socket = create_socket(&device_info).await;
let request = WebsocketMessageToDevice {
device_id: device_info.device_id.to_string(),
payload: "message from test".to_string(),
};
let serialized_request = serde_json::to_string(&request)
.expect("Failed to serialize connection request");
println!("request: {}", serialized_request);
socket
.send(Message::Text(serialized_request))
.await
.expect("Failed to send message");
}- Open RabbitMQ management console, there should be one dropped message (there is no device with test_persist ID)
- Open DynamoDB console, message should be persisted:
- Additionally, check TB logs for:
2023-09-28T12:52:08.492774Z DEBUG tunnelbroker::websockets::session: Received message for ZXx1ADCFxFm6P+UmVhX0A1tuqUoBU7lYjig/gMzSEJI 2023-09-28T12:52:08.492789Z DEBUG tunnelbroker::database: Persisting message to device: ZXx1ADCFxFm6P+UmVhX0A1tuqUoBU7lYjig/gMzSEJI
- Run:
cd services/commtest && cargo test --test tunnelbroker_persist_tests -- --nocapture
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/commtest/tests/tunnelbroker_persist_tests.rs | ||
|---|---|---|
| 83 ↗ | (On Diff #31526) | comment says 50 while in code there's 500 |
| services/commtest/tests/tunnelbroker_persist_tests.rs | ||
|---|---|---|
| 83 ↗ | (On Diff #31526) | whoops, I changed it to check something and forgot to restore correct value, I will update before landing |
| services/commtest/tests/tunnelbroker_persist_tests.rs | ||
|---|---|---|
| 83 ↗ | (On Diff #31526) | It's better to avoid repeating what is already in the code so that we don't have to remember to update both values simultaneously. In this case, we can say e.g.
|
| 85 ↗ | (On Diff #31526) | Doesn't look like ten_millis. Maybe wait_duration? |
| services/commtest/tests/tunnelbroker_persist_tests.rs | ||
|---|---|---|
| 86 ↗ | (On Diff #31526) | This is a test so probably doesn't matter but we should use tokio::sleep in async contexts. |
| services/commtest/tests/tunnelbroker_persist_tests.rs | ||
|---|---|---|
| 86 ↗ | (On Diff #31526) | Good call. We should replace it with tokio::sleep because thread::sleep might block the whole runtime (all tasks), so it also blocks other tests if they run concurrently. From my experience, even with rt_multi_thread (Tokio default), it tends to spawn all tasks on one thread so if it gets blocked, it effectively blocks the whole runtime. |