[Commtest] add mock olm accounts, configure creating authenticated device
ClosedPublic
Actions

Authored by kamil on Sep 28 2023, 7:30 AM.

Details

Reviewers

michal
bartek
varun
• jon

Commits

rCOMMa21779658cfe: [Commtest] add mock olm accounts, configure creating authenticated device

Summary

To properly test WebSocket one device is not enough. We should send message from one device and receive it on another.
Adding two more, generated via local olm.

Depends on D9311

Test Plan

Run tests and make sure new credentials works.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Sep 28 2023, 7:30 AM

kamil held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptSep 28 2023, 7:30 AM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

kamil added a child revision: D9313: [Tunnelbroker] always persist gRPC messages in database.Sep 28 2023, 7:35 AM

Harbormaster completed remote builds in B22891: Diff 31522.Sep 28 2023, 7:48 AM

kamil published this revision for review.Sep 28 2023, 8:09 AM

bartek accepted this revision.Sep 29 2023, 1:07 AM

bartek added inline comments.

services/commtest/src/identity/device.rs
22 ↗	(On Diff #31522)	Looking at usages below, this could be `Option<&ClientPublicKeys>` to avoid cloning `DEFAULT_CLIENT_KEYS` and referencing `&keys`. Anyway it's a test so not a big deal
31–34 ↗	(On Diff #31522)	This way is preferred
services/commtest/src/identity/olm_account_infos.rs
17 ↗	(On Diff #31522)	Not directly related to this diff, but in the future we could replace `lazy_static` with `once_cell`