- We need to make sure that each message is delivered to client.
- We need to persist it immediately after receiving
- Message will be removed after confirmation from client
Depends on D9312
Details
Details
- Restart RabbitMQ
- Restart localstack
- Run this code:
#[tokio::test]
async fn send_grpc() {
let refresh_request = RefreshKeyRequest {
device_id: "test_persist".to_string(),
number_of_keys: 5,
};
let request = MessageToDevice {
device_id: "test_persist".to_string(),
payload: serde_json::to_string(&refresh_request).unwrap(),
};
let grpc_message = tonic::Request::new(request);
TunnelbrokerServiceClient::connect("http://localhost:50051")
.await
.unwrap()
.send_message_to_device(grpc_message)
.await
.unwrap();
}- Open RabbitMQ management console, there should be one dropped message (there is no device with test_persist ID)
- Open DynamoDB console, message should be persisted:
- Additionally, check TB logs for:
2023-09-27T13:47:23.107877Z DEBUG tunnelbroker::grpc: Received message for test_persist 2023-09-27T13:47:23.107920Z DEBUG tunnelbroker::database: Persisting message to device: test_persist
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Did you think of expected behavior in case of failure?
Current code aborts publishing a message to RabbitMQ if DDB persistence fails. Is that expected?
Comment Actions
Yes, created ENG-5149 to discuss this, initially I wanted to implement option 2, but probably we can discuss it.
Current code aborts publishing a message to RabbitMQ if DDB persistence fails. Is that expected?
Yes, this diff intention to make it mandatory to put messages in DDB. Failures are separate thing, handling will be tracked in ENG-5149.