Page MenuHomePhabricator
Differential D9409

[web] introduce UserProfile component
ClosedPublic
Actions

Authored by ginsu on Oct 8 2023, 11:45 PM.
Tags
None
Referenced Files
F3519613: D9409.id.diff
Sun, Dec 22, 10:43 PM
Unknown Object (File)
Fri, Dec 20, 8:33 PM
Unknown Object (File)
Tue, Dec 3, 7:09 PM
Unknown Object (File)
Fri, Nov 29, 9:13 PM
Unknown Object (File)
Sun, Nov 24, 8:47 AM
Unknown Object (File)
Nov 20 2024, 11:07 PM
Unknown Object (File)
Nov 15 2024, 6:10 AM
Unknown Object (File)
Nov 14 2024, 7:26 AM
View All 97 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
Commits
rCOMM5594443dcdb9: [web] introduce UserProfile component
Summary

This diff introduces the barebones user profile component. This includes the user avatar, the username, and the copy username button (but w/o the functionality). That and the other elements of the user profile will come in subsequent diffs

https://linear.app/comm/issue/ENG-4962/introduce-user-profile-component

Depends on D9408

Test Plan

Please see screenshot below

Screenshot 2023-10-09 at 2.55.21 AM.png (2×3 px, 752 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 8 2023, 11:45 PM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 8 2023, 11:45 PM
ginsu edited the summary of this revision. (Show Details)Oct 8 2023, 11:55 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D9408: [web] introduce XL and XXL sizes to the avatar component.
ginsu attached a referenced file: F804376: Screenshot 2023-10-09 at 2.55.21 AM.png. (Show Details)
ginsu added a child revision: D9410: [web] introduce UserProfileModal component.Oct 9 2023, 12:00 AM
Harbormaster completed remote builds in B23076: Diff 31769.Oct 9 2023, 12:03 AM
ginsu requested review of this revision.Oct 9 2023, 12:03 AM
atul requested changes to this revision.Oct 9 2023, 1:49 PM

If we're allowing ?UserInfo for userInfo prop, shouldn't we eg render "Copy username" conditionally? Or maybe userInfo can be UserInfo?

web/modals/user-profile/user-profile.react.js
13 ↗(On Diff #31769)

How does this component appear if userInfo is null or undefined?

If this is a scenario we're considering, shouldn't eg "Copy username" be displayed conditionally?

22–31 ↗(On Diff #31769)

Wouldn't hurt to memoize

This revision now requires changes to proceed.Oct 9 2023, 1:49 PM
ginsu added inline comments.Oct 13 2023, 11:07 AM
web/modals/user-profile/user-profile.react.js
13 ↗(On Diff #31769)

Currently this is the behavior:

Clicking "Copy username" will copy the username text which is anonymous. This is the same behavior as native as well

ginsu updated this revision to Diff 31996.Oct 13 2023, 11:08 AM

address @atul's feedback

ginsu attached a referenced file: F813036: Screen Recording 2023-10-13 at 2.03.07 PM.mov. (Show Details)Oct 13 2023, 11:08 AM
Harbormaster completed remote builds in B23240: Diff 31996.Oct 13 2023, 11:26 AM
atul accepted this revision.Oct 16 2023, 4:46 PM
This revision is now accepted and ready to land.Oct 16 2023, 4:46 PM
ginsu updated this revision to Diff 32047.Oct 16 2023, 9:49 PM

rebase before landing

Harbormaster completed remote builds in B23270: Diff 32047.Oct 16 2023, 10:06 PM
Closed by commit rCOMM5594443dcdb9: [web] introduce UserProfile component (authored by ginsu). · Explain WhyOct 16 2023, 10:58 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM5594443dcdb9: [web] introduce UserProfile component.

Revision Contents
Changeset List

PathSize
web/
modals/
user-profile/
33 lines
40 lines

Diff 32062

View Options

web/modals/user-profile/user-profile.css

Loading...
View Options

web/modals/user-profile/user-profile.react.js

Loading...