Page MenuHomePhabricator
Differential D9455

[web] introduce secondaryHeaderButton prop to Modal component
ClosedPublic
Actions

Authored by ginsu on Oct 12 2023, 12:52 AM.
Tags
None
Referenced Files
F2208611: D9455.id32068.diff
Sun, Jul 7, 2:29 PM
Unknown Object (File)
Thu, Jul 4, 10:59 PM
Unknown Object (File)
Sat, Jun 29, 11:04 PM
Unknown Object (File)
Sat, Jun 29, 6:07 PM
Unknown Object (File)
Fri, Jun 28, 10:30 PM
Unknown Object (File)
Thu, Jun 27, 12:32 AM
Unknown Object (File)
Wed, Jun 26, 8:28 PM
Unknown Object (File)
Mon, Jun 24, 9:19 PM
View All 90 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
Commits
rCOMMfbf257c255a8: [web] introduce secondaryHeaderButton prop to Modal component
Summary

As a preliminary step to introducing the user profile menu component, we need to update the modal component. This diff makes two changes to the Modal component API

  1. Made the name prop optional
  2. introduce secondaryHeaderButton

Linear task: https://linear.app/comm/issue/ENG-5190/update-modal-component

Depends on D9447

Test Plan

Please see the screenshot where I pass in a UserProfileMenu component (will be introduced in a subsequent diff) as the secondaryHeaderButton

Screenshot 2023-10-12 at 3.56.54 AM.png (1×3 px, 938 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 12 2023, 12:52 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 12 2023, 12:52 AM
ginsu updated this revision to Diff 31952.Oct 12 2023, 12:54 AM

update

ginsu edited the summary of this revision. (Show Details)Oct 12 2023, 12:57 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D9447: [web] implement RelationshipPromptButtons into user profiles.
ginsu attached a referenced file: F809991: Screenshot 2023-10-12 at 3.56.54 AM.png. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 12 2023, 1:00 AM
Harbormaster failed remote builds in B23200: Diff 31952!
ginsu added a child revision: D9456: [web] introduce user-profile as a menu variant.Oct 12 2023, 1:05 AM
ginsu updated this revision to Diff 31954.Oct 12 2023, 1:09 AM

update

Harbormaster completed remote builds in B23199: Diff 31951.Oct 12 2023, 1:10 AM
Harbormaster completed remote builds in B23202: Diff 31954.Oct 12 2023, 1:26 AM
ginsu requested review of this revision.Oct 12 2023, 1:26 AM
atul accepted this revision.Oct 16 2023, 9:32 AM
atul added inline comments.
web/modals/modal.react.js
88–104 ↗(On Diff #31954)

Can memoize this guy

web/modals/user-profile/user-profile-modal.react.js
26 ↗(On Diff #31954)

Glad we could clean this up

This revision is now accepted and ready to land.Oct 16 2023, 9:32 AM
ginsu updated this revision to Diff 32054.Oct 16 2023, 10:21 PM

address atul's comments + rebase before landing

Harbormaster completed remote builds in B23277: Diff 32054.Oct 16 2023, 10:38 PM
Closed by commit rCOMMfbf257c255a8: [web] introduce secondaryHeaderButton prop to Modal component (authored by ginsu). · Explain WhyOct 16 2023, 10:58 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMfbf257c255a8: [web] introduce secondaryHeaderButton prop to Modal component.

Revision Contents
Changeset List

PathSize
web/
modals/
11 lines
80 lines
user-profile/
2 lines

Diff 32068

View Options

web/modals/modal.css

Loading...
View Options

web/modals/modal.react.js

Loading...
View Options

web/modals/user-profile/user-profile-modal.react.js

Loading...