Page MenuHomePhabricator
Differential D9457

[web] introduce UserProfileMenu
ClosedPublic
Actions

Authored by ginsu on Oct 12 2023, 1:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 2, 2:08 AM
Unknown Object (File)
Sun, Jun 30, 4:50 PM
Unknown Object (File)
Sun, Jun 30, 10:20 AM
Unknown Object (File)
Thu, Jun 27, 4:17 PM
Unknown Object (File)
Wed, Jun 26, 10:30 PM
Unknown Object (File)
Wed, Jun 26, 7:57 AM
Unknown Object (File)
Tue, Jun 25, 7:49 AM
Unknown Object (File)
Mon, Jun 24, 2:56 AM
View All 73 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
Commits
rCOMMc603bb315131: [web] introduce UserProfileMenu
Summary

This diff introduces the UserProfileMenu component. This component handles showing the correct relationship action options based on what the current relationship status of the viewer and the profile is.

Here are the figma designs:

When user is a friend:

Screenshot 2023-10-12 at 4.24.25 AM.png (1×1 px, 284 KB)

When viewer is blocked (couldn't find native designs but the concept is the same here):

Screenshot 2023-10-12 at 4.25.33 AM.png (1×1 px, 215 KB)

When user is blocked by viewer:

Screenshot 2023-10-12 at 4.26.04 AM.png (1×1 px, 292 KB)

When there is no relationship status between user/viewer, or there is a pending friend request in either direction:

Screenshot 2023-10-12 at 4.26.26 AM.png (1×1 px, 275 KB)

Part of https://linear.app/comm/issue/ENG-5225/introduce-userprofilemenu

Depends on D9456

Test Plan

Please see the screenshots below. Also confirmed that the actions worked as expected

When user is a friend:

Screenshot 2023-10-12 at 4.27.28 AM.png (1×3 px, 956 KB)

When viewer is blocked:

Screenshot 2023-10-12 at 4.29.16 AM.png (1×3 px, 950 KB)

When user is blocked by viewer:

Screenshot 2023-10-12 at 4.28.23 AM.png (1×3 px, 950 KB)

When there is no relationship status between user/viewer, or there is a pending friend request in either direction:

Screenshot 2023-10-12 at 4.27.54 AM.png (1×3 px, 949 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 12 2023, 1:22 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 12 2023, 1:22 AM
ginsu edited the summary of this revision. (Show Details)Oct 12 2023, 1:29 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D9456: [web] introduce user-profile as a menu variant.
ginsu attached a referenced file: F810095: Screenshot 2023-10-12 at 4.27.54 AM.png. (Show Details)
ginsu attached a referenced file: F810096: Screenshot 2023-10-12 at 4.28.23 AM.png. (Show Details)
ginsu attached a referenced file: F810097: Screenshot 2023-10-12 at 4.29.16 AM.png. (Show Details)
ginsu attached a referenced file: F810094: Screenshot 2023-10-12 at 4.27.28 AM.png. (Show Details)
ginsu attached a referenced file: F810093: Screenshot 2023-10-12 at 4.26.26 AM.png. (Show Details)
ginsu attached a referenced file: F810091: Screenshot 2023-10-12 at 4.26.04 AM.png. (Show Details)
ginsu attached a referenced file: F810090: Screenshot 2023-10-12 at 4.25.33 AM.png. (Show Details)
ginsu attached a referenced file: F810089: Screenshot 2023-10-12 at 4.24.25 AM.png. (Show Details)
ginsu added a child revision: D9458: [web] intorduce user profile menu to user profile modal.Oct 12 2023, 1:35 AM
Harbormaster completed remote builds in B23203: Diff 31955.Oct 12 2023, 1:40 AM
ginsu requested review of this revision.Oct 12 2023, 1:40 AM
atul accepted this revision.Oct 16 2023, 11:16 AM
This revision is now accepted and ready to land.Oct 16 2023, 11:16 AM
ginsu updated this revision to Diff 32056.Oct 16 2023, 10:33 PM

rebase before landing

Harbormaster completed remote builds in B23279: Diff 32056.Oct 16 2023, 10:51 PM
Closed by commit rCOMMc603bb315131: [web] introduce UserProfileMenu (authored by ginsu). · Explain WhyOct 16 2023, 10:58 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMc603bb315131: [web] introduce UserProfileMenu.

Revision Contents
Changeset List

PathSize
web/
modals/
user-profile/
111 lines

Diff 32070

View Options

web/modals/user-profile/user-profile-menu.react.js

Loading...